1589087 - Latest Firefox Preview Nightly doesn't have a $version in Remote Debugging

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P3)

Description

[:Harald Kirschner :digitarald]

Attachment: image.png

STR: Connext Firefox Preview Nightly in Remote Debugging

AR: Title is Firefox Preview Nightly ({$version})

ER: Version shown

Comment 1

[Julian Descottes [:jdescottes]]

Thanks for filing, mentioned it in https://github.com/mozilla-mobile/fenix/issues/2016

Comment 2

[Julian Descottes [:jdescottes]]

Initial workaround was to use a version retrieved from ADB as explained in https://bugzilla.mozilla.org/show_bug.cgi?id=1542286#c9

Comment 3

[Julian Descottes [:jdescottes]]

The exact code we are using at the moment to retrieve the version is

  async init() {
    const packageName = this._packageName();
    const query = `dumpsys package ${packageName} | grep versionName`;
    const versionNameString = await shell(this._adbDevice.id, query);
    const matches = versionNameString.match(/versionName=([\d.]+)/);
    if (matches && matches[1]) {
      this._versionName = matches[1];
    }
  }

https://searchfox.org/mozilla-central/rev/171109434c6f2fe086af3b2322839b346a112a99/devtools/shared/adb/adb-runtime.js#19-23

Comment 4

[Julian Descottes [:jdescottes]]

It looks like the version number is now Nightly 191016 06:01 on Nightly builds of Firefox Preview, so it no longer matches our regexp. We can update the regexp to be a bit more flexible, but I mentioned it in #fission on slack because this seems weird as a version number.

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: fixed_screenshot.png

Fixed it but it's not looking great :)

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1589087 - Update regular expression used in ADB to extract Fenix version

The format of the Fenix versionName on Nightly no longer matches our regular expression.
Updating the regular expression to accommodate both versions such as "2.1.0" and "Nightly 191016 06:01"

Comment 7

[:Harald Kirschner :digitarald]

Fixed it but it's not looking great :)

Mh, but probably good enough for Nightly for the moment.

Comment 8

[Julian Descottes [:jdescottes]]

For some more context, the version format changed in https://github.com/mozilla-mobile/fenix/pull/3742
The goal was to have more granularity and avoid clashes when several builds occur on the same day.
The actual format is not set in stone and might be updated later if the fenix team decides to do so.

The release version format remains X.Y.Z

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f042cb2f447c
Update regular expression used in ADB to extract Fenix version r=ladybenko

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f042cb2f447c