1589138 - Make BrowserTestUtils.addContentEventListener take an options object for the listener

Status: RESOLVED FIXED

(Testing :: Mochitest, task, P2)

Description

[Andrew McCreight [:mccr8]]

This method takes two booleans that it passes along as arguments to addEventListener. kmag pointed out that it would make more sense to take a single argument that is an event listener options object. This reduces the amount of plumbing a little bit, and allows for future flexibility.

Of the tests that use these extra options, all but browser_bug744745.js pass without being fixed, which seems a little weird.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1589138 - Make addContentEventListener take an options object for the listener.

All but browser_bug744745.js seem to pass even without the fixes I
made, which seems odd.

browser_bug1058164.js is a little odd because it passes in {} instead
of a boolean for the useCapture argument. I think this ends up calling
addEventListener(..., {}, false), which should be the equivalent of
addEventListener(..., {}).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca55578623da
Make addContentEventListener take an options object for the listener. r=Gijs

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ca55578623da