Open Bug 1589187 Opened 5 years ago Updated 2 years ago

Re-evaluate file size warnings/errors when vendoring rust code

Categories

(Firefox Build System :: General, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: chmanchester, Unassigned)

References

Details

This check as implemented doesn't seem to entirely align with what we're trying to do. I've been pinged a few times about adding large source files (the current check fails for individual files >100k), but the check as intended seems more concerned with large test case inputs or huge numbers of files (although it only warns in case of the latter). If someone wants to add an upstream library that happens to be implemented via a small number of large source files we don't really have much of substance to offer as an alternative.

With an ok from vcs I'd like to modify the check to have a larger limit for individual files (perhaps especially for ones that look like source code) and a hard error for large totals, or another heuristic that aligns with cases that will most likely impact hg performance.

Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.