1589203 - Browsertime's --setup ImageMagick binary link for macOS is 404/outdated/broken

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

I ran our Browsertime-setup command today, and got a 404 on macOS:

stephendonner-7hlvdq:mozilla-unified stephendonner$ ./mach browsertime --setup

 0:00.56 Downloading... 0.0 %
 0:00.56 Downloading... 100.0 %
Error running mach:

    ['browsertime', '--setup']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

HTTPError: 404 Client Error: Not Found for url: https://imagemagick.org/download/binaries/ImageMagick-x86_64-apple-darwin17.7.0.tar.gz

I think the fix is to manually update/fix the URI, here: https://searchfox.org/mozilla-central/rev/97976753a21c1731e18177de9e5ce78ea3b3da2d/tools/browsertime/mach_commands.py#109-116

to: https://imagemagick.org/download/binaries/ImageMagick-x86_64-apple-darwin18.7.0.tar.gz

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Bug 1589203: Browsertime's --setup ImageMagick binary link for macOS is 404/outdated/broken. r?#perftest

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Pushed to try here: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=2e9046a54b553b093898757c4a0c66c313e6e06b

This fixes it for me:

 0:00.42 Downloading to temporary location /Users/stephendonner/.mozbuild/cache/browsertime/9ac930ee5a39c772-ImageMagick-x86_64-apple-darwin18.7.0.tar.gz
 0:00.42 Downloaded artifact to /Users/stephendonner/.mozbuild/cache/browsertime/9ac930ee5a39c772-ImageMagick-x86_64-apple-darwin18.7.0.tar.gz
 0:00.42 Unpacking temporary location /Users/stephendonner/.mozbuild/cache/browsertime/9ac930ee5a39c772-ImageMagick-x86_64-apple-darwin18.7.0.tar.gz
 0:01.01 Downloading to temporary location /Users/stephendonner/.mozbuild/cache/browsertime/ac79da076f1ab59d-ffmpeg-4.1.1-macos64-static.zip
 0:01.01 Downloaded artifact to /Users/stephendonner/.mozbuild/cache/browsertime/ac79da076f1ab59d-ffmpeg-4.1.1-macos64-static.zip
 0:01.01 Unpacking temporary location /Users/stephendonner/.mozbuild/cache/browsertime/ac79da076f1ab59d-ffmpeg-4.1.1-macos64-static.zip
 0:02.13 Installing browsertime node module from /Users/stephendonner/mozilla-source/mozilla-unified/tools/browsertime/package.json
Clobbering /Users/stephendonner/mozilla-source/mozilla-unified/tools/browsertime/node_modules...
Installing browsertime for mach using "/Users/stephendonner/.mozbuild/node/bin/node /Users/stephendonner/.mozbuild/node/bin/npm install --loglevel=error"...
info sharp Using cached /Users/stephendonner/.npm/_libvips/libvips-8.7.4-darwin-x64.tar.gz

browsertime installed successfully!

NOTE: Your local browsertime binary is at /Users/stephendonner/mozilla-source/mozilla-unified/tools/browsertime/node_modules/.bin/browsertime```

Comment 3

[Robert Wood [:rwood]]

Hey :stephend, is this still an issue? I am pretty sure that I ran ./mach browsertime --setup locally on my OSX the other day and it worked fine (is it just some reason it works on my OSX)?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1597aabe314b
Browsertime's --setup ImageMagick binary link for macOS is 404/outdated/broken. r=perftest-reviewers,sparky

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Robert Wood [:rwood] from comment #3)

Hey :stephend, is this still an issue? I am pretty sure that I ran ./mach browsertime --setup locally on my OSX the other day and it worked fine (is it just some reason it works on my OSX)?

Hi Rob - sorry, didn't meant to land without answering; yes, I still experience this 404 with the old code, and am baffled (but believe) if it's working for others, as to how:

https://gist.github.com/stephendonner/265aa808697f380d1eae3fd29a4a2825

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1597aabe314b