Closed
Bug 1589241
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 19743 - [Import Maps] WPT: Check parsed import maps' scopes
Categories
(Testing :: web-platform-tests, task, P4)
Testing
web-platform-tests
Tracking
(firefox72 fixed)
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 19743 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/19743
Details from upstream follow.
Hiroshige Hayashizaki <hiroshige@chromium.org> wrote:
[Import Maps] WPT: Check parsed import maps' scopes
Before this CL, only
importsparts of import maps were tested.Chromium side:
- This CL makes ImportMap::ToString() to output the whole import map,
rather than only theimportsvalue.- This CL removes white spaces for pretty printing, to simplify
the logic.WPT side:
- This CL checks the whole import maps in
jest-test-helper.js.- Reflect the upstream changes in
https://github.com/WICG/import-maps/pull/190 to
builtin-support.tentative/imported/resources/parsing-scope-keys.js.Test expectation changes:
- This CL exposes new test failures in
parsing-scope-keys.tentative.htmlon Chromium
due to the spec-inconformant behavior of Chromium's URL parser.- Other test expectation changes are just converting
xto{imports: x, scopes: {}}.Bug: 990561, 927181
Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345Reviewed-on: https://chromium-review.googlesource.com/1863854
WPT-Export-Revision: a7f4e851cf9d90b14a8a18dcc7df5915bcfcbc80
| Assignee | ||
Comment 1•6 years ago
|
||
PR 19743 applied with additional changes from upstream: 2a907985ffc3ea3455fe277c584cadfe70b53623
| Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f85351cce632722de21be3884c08f88d902dbb1e
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52907e7e763b
[wpt PR 19743] - [Import Maps] WPT: Check parsed import maps' scopes, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/26be487ed78a
[wpt PR 19743] - Update wpt metadata, a=testonly
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/52907e7e763b
https://hg.mozilla.org/mozilla-central/rev/26be487ed78a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•