Closed Bug 1589241 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 19743 - [Import Maps] WPT: Check parsed import maps' scopes

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19743 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19743
Details from upstream follow.

Hiroshige Hayashizaki <hiroshige@chromium.org> wrote:

[Import Maps] WPT: Check parsed import maps' scopes

Before this CL, only imports parts of import maps were tested.

Chromium side:

  • This CL makes ImportMap::ToString() to output the whole import map,
    rather than only the imports value.
  • This CL removes white spaces for pretty printing, to simplify
    the logic.

WPT side:

Test expectation changes:

  • This CL exposes new test failures in
    parsing-scope-keys.tentative.html on Chromium
    due to the spec-inconformant behavior of Chromium's URL parser.
  • Other test expectation changes are just converting
    x to {imports: x, scopes: {}}.

Bug: 990561, 927181
Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345

Reviewed-on: https://chromium-review.googlesource.com/1863854
WPT-Export-Revision: a7f4e851cf9d90b14a8a18dcc7df5915bcfcbc80

PR 19743 applied with additional changes from upstream: 2a907985ffc3ea3455fe277c584cadfe70b53623
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/52907e7e763b [wpt PR 19743] - [Import Maps] WPT: Check parsed import maps' scopes, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/26be487ed78a [wpt PR 19743] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.