1589248 - Consolidate hardcoded layouts

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Gavin Suntop [:gvn] (they/them)]

The DiscoveryStreamFeed.jsm is getting really large and it would make things cleaner and more maintainable if we can move the hardcoded layouts into their own JSON files.

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Based on conversations we've decided to consolidate to a single hardcoded layout with branching logic within for necessary locale variations.

Comment 2

[Gavin Suntop [:gvn] (they/them)]

Attachment: merging 2 hardcoded layouts into 1

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7910393bf14a
merging 2 hardcoded layouts into 1 r=thecount

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 7910393bf14a (bug 1589248) for Newtab failures on karma | activity-stream:DiscoveryStreamFeed:#loadLayout. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290287625&repo=autoland&lineNumber=283

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=7910393bf14aa64dbfaaea8e40df761a00cc0580&selectedJob=290287625

Backout:
https://hg.mozilla.org/integration/autoland/rev/f0bc876aaa6f3b25a5f4961f9105f5482db1a8f4

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e948271a7a7
merging 2 hardcoded layouts into 1 r=thecount

Comment 6

[Gavin Suntop [:gvn] (they/them)]

Fixed test.

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7e948271a7a7