1589273 - mozregression-gui "good" and "bad" buttons are tiny and truncate button text on Windows

Status: RESOLVED FIXED

(Testing :: mozregression, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: mozregression-0.9.42_screenshot.png

Please see the attached screenshot. I'm using mozregression-gui 0.9.42 on Windows 10.

This is not a new bug. I just finally got around to filing it. :)

Comment 1

[BugBot [:suhaib / :marco]]

The priority flag is not set for this bug.
:wlach, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[William Lachance (:wlach)]

Hmm, weird. Probably not too hard for someone to solve.

Comment 3

[William Lachance (:wlach)]

I believe this should be fixed on master, with the port to PySide2. Please reopen if it's still a problem for you.

Comment 4

[Chris Peterson [:cpeterson]]

Reopening because this is still a problem in version 4.0.0pre4 on Windows 10.

The "Testing" rows and "Good" and "Bad" buttons are taller in 4.0.0pre4 than in gui-0.9.x, which is nice! But the buttons are still too narrow. The "Good" button label just shows "Goo" without the green circle or letter 'd'. The "Bad" button truncates part of the red circle. The "Testing" rows are very wide, so there's plenty of room to expand the buttons. :)

Also, the "other..." button is shorter (instead of slightly taller like in gui-0.9.x) than the "Good" and "Bad" buttons.

I'll attach a new screenshot.

Comment 5

[Chris Peterson [:cpeterson]]

Attachment: mozregression-4.4.0rc4_screenshot.png

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/mozregression/pull/606

Comment 7

[William Lachance (:wlach)]

How mystifying! I can't reproduce this at all here. Here's a build where I set the size policy on these buttons to fixed (which works here, but doesn't change anything):

https://ci.appveyor.com/project/wlach/mozregression/builds/32208033/artifacts

Can you give it a try and let me know if it improves anything?

Comment 8

[Chris Peterson [:cpeterson]]

Attachment: mozregression-0.9.47.dev49_screenshot.png

(In reply to William Lachance (:wlach) (use needinfo!) from comment #7)

https://ci.appveyor.com/project/wlach/mozregression/builds/32208033/artifacts

Can you give it a try and let me know if it improves anything?

I see no difference in the button widths. See this new screenshot.

btw, I installed that build successfully, but when I try to run mozregression-gui, I see this a (non-fatal) "Crash Dialog" window saying:

platform: Windows-10-10.0.19041-SP0
python: 3.7.5 FROZEN (32bit)
mozregression: 0.9.47.dev49+gdbd27d7
message: KeyError: 'tag_name'
traceback: File "mozregui\check_release.py", line 19, in run

Comment 9

[William Lachance (:wlach)]

(In reply to Chris Peterson [:cpeterson] from comment #8)

Created attachment 9140892 [details]
mozregression-0.9.47.dev49_screenshot.png

(In reply to William Lachance (:wlach) (use needinfo!) from comment #7)

https://ci.appveyor.com/project/wlach/mozregression/builds/32208033/artifacts

Can you give it a try and let me know if it improves anything?

I see no difference in the button widths. See this new screenshot.

Ok, fiddled around a bit more with sizing policies, this time setting the buttons to have a fixed width. Can you try once again?

https://ci.appveyor.com/project/wlach/mozregression/builds/32227657/artifacts

Something about your system is pretty different from mine, but can't find any good reference to it online. I'm not so interested/able to become an expert with PyQt, so we might need to leave this open for now if this doesn't help.

btw, I installed that build successfully, but when I try to run mozregression-gui, I see this a (non-fatal) "Crash Dialog" window saying:

platform: Windows-10-10.0.19041-SP0
python: 3.7.5 FROZEN (32bit)
mozregression: 0.9.47.dev49+gdbd27d7
message: KeyError: 'tag_name'
traceback: File "mozregui\check_release.py", line 19, in run

Hmm... I think that's an intermittent github issue of some kind-- it doesn't seem worth bothering the user about, I filed another PR about it: https://github.com/mozilla/mozregression/pull/614

Comment 10

[Chris Peterson [:cpeterson]]

(In reply to William Lachance (:wlach) (use needinfo!) from comment #9)

Ok, fiddled around a bit more with sizing policies, this time setting the buttons to have a fixed width. Can you try once again?

https://ci.appveyor.com/project/wlach/mozregression/builds/32227657/artifacts

I tested this new build. The buttons are definitely taller, but their widths are unchanged.

Something about your system is pretty different from mine, but can't find any good reference to it online. I'm not so interested/able to become an expert with PyQt, so we might need to leave this open for now if this doesn't help.

No problem. The buttons still work and that's what matters! :) I like these taller buttons, so I recommend landing your latest fix even though it doesn't fix the button widths.

I'm not sure what's unique about my system. I try to avoid customizing my system too much. I'm using the default app scaling ("250% (Recommended)").

Comment 11

[William Lachance (:wlach)]

(In reply to Chris Peterson [:cpeterson] from comment #10)

I'm not sure what's unique about my system. I try to avoid customizing my system too much. I'm using the default app scaling ("250% (Recommended)").

Aha! That was it, apparently you need to set a configuration setting in your app on Windows to respect the OS scaling setting. Can you try the build here? It seems to work for me with scaling adjusted:

https://ci.appveyor.com/project/wlach/mozregression/builds/32257859/artifacts

Comment 12

[Chris Peterson [:cpeterson]]

Attachment: mozregression-scaled_screenshot.png

(In reply to William Lachance (:wlach) (use needinfo!) from comment #11)

Aha! That was it, apparently you need to set a configuration setting in your app on Windows to respect the OS scaling setting. Can you try the build here? It seems to work for me with scaling adjusted:

LGTM! The buttons are nice and big. Here's a screenshot. I think you can close this bug as fixed.

Comment 13

[William Lachance (:wlach)]

Great! Thanks for testing. I'll release something early next week.