Closed Bug 1589358 Opened 3 years ago Closed 3 years ago

'mach try fuzzy' and fzf version requirements

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: sfraser, Assigned: sfraser)

Details

Attachments

(1 file)

Bug 1589358 Force update of older fzf versions r=jlorenzo
47 bytes, text/x-phabricator-request
Details | Review

The newer 'show-estimates' preview window in fzf requires the FZF_PREVIEW_COLUMNS environment variable to be set, which is available from 0.18.0 onwards. We should force an update for the mozbuild copy of fzf if used.

Assignee: nobody → sfraser

If 'fzf' was installed by mach, then check it's up to date and force update if needed.

Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f1a6b95582a
Force update of older fzf versions r=jlorenzo

This change looks good, but for future reference please flag me for review on changes under tools/tryselect. I likely would have had some comments on bug 1585998.

https://hg.mozilla.org/mozilla-central/rev/6f1a6b95582a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED

(In reply to Andrew Halberstadt [:ahal] from comment #3)

This change looks good, but for future reference please flag me for review on changes under tools/tryselect. I likely would have had some comments on bug 1585998.

Apologies, I will do so in future. Are there any changes you'd like me to make?

You need to log in before you can comment on or make changes to this bug.