1589459 - No edit context menu appears in Search field of Addons Manager -> Extensions

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[Alice0775 White]

Steps To Reproduce:

1. Open Add-ons Manager
2. Select "Extensions" of left pane
3. Right click on search field on top of the right pane

Actual Results:
Nothing happens

Expected Results:
Edit context menu should appear

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=0578849d7c953f13f6b8c6c57c1054b5a445c317&tochange=55a635377bed6cdeb57175d7e25a67b34dfce540
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a42caa9f04fc41044437ac56eab6f6086c841d9f&tochange=2abcefb31ba7b2a1c573edc5695b772826c6a078

Regressed by: 55a635377bed6cdeb57175d7e25a67b34dfce540 Magnus Melin — Bug 1534913 - Port bug 1521280 [Remove search-textbox binding] to Thunderbird. r=jorgk

Comment 1

[Jorg K (CEST = GMT+2)]

Grrrr, yet another one. We've already added the damn scripts for the filter manager, config editor, password manager and downloads manager in bug 1584720.

But that add-ons manager is an M-C piece, right?

Comment 2

[Geoff Lankow (:darktrojan)]

It is but it's probably related to the other context menu problems we are having in about: pages. Alessandro's working on that.

Comment 3

[Magnus Melin [:mkmelin]]

I'm not sure why Firefox doesn't show this problem, since they do not include the needed js files (in extensions.xul). Anyway, I guess we could add the script elements in aboutAddonsExtra.js somewhere? And while at it, remove the "on" - https://searchfox.org/comm-central/rev/dbc116c2b1bcb8d1c50af5d45b750af2a174a9e3/mail/base/content/aboutAddonsExtra.js#61

Comment 4

[Richard Marti (:Paenglab)]

It's because they use the HTML Add-ons manager.

Comment 5

[Jorg K (CEST = GMT+2)]

So which resource would you like to dedicate to this, Magnus?

Comment 6

[Magnus Melin [:mkmelin]]

(In reply to Richard Marti (:Paenglab) from comment #4)

It's because they use the HTML Add-ons manager.

I don't think so? Where is that?

Looking into this a bit, turns out it's not directly fixable outside of adding the needed js includes to extensions.xul. (CSP on the page won't allow us to make use of the scripts properly)

Comment 7

[Alessandro Castellani [:aleca]]

I wasn't able to fix the about:config issue in bug 1584795 as a patch in m-c was needed.

Comment 8

[Magnus Melin [:mkmelin]]

Maybe not be worth doing anything about for 68, and things could be a lot different before we get to 78.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: bug1589459_addons_input_context.patch

At least for trunk, turns out this due to bug 1472785.
We should just turn on the context menu.

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9126716 [details] [diff] [review]
bug1589459_addons_input_context.patch

Review of attachment 9126716 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/aboutAddonsExtra.js
@@ +26,5 @@
>      document.insertBefore(contentStylesheet, document.documentElement);
>  
>      // Fix the "Search on addons.mozilla.org" placeholder text in the searchbox.
>      let browser = document.getElementById("html-view-browser");
> +    browser.contentWindow.addEventListener("DOMContentLoaded", () => {

This doesn't work (for me). Probably DOMContentLoaded has already happened.

Comment 11

[Magnus Melin [:mkmelin]]

Attachment: bug1589459_addons_input_context.patch

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: bug1589459_addons_input_context.patch

Comment 13

[Magnus Melin [:mkmelin]]

Attachment: bug1589459_addons_input_context.patch

Comment 14

[Geoff Lankow (:darktrojan)]

Comment on attachment 9127568 [details] [diff] [review]
bug1589459_addons_input_context.patch

Well it works but it's seriously ugly IMO. This is what I'd do, use whichever one makes you happy:
```
if (!/(interactive|complete)/.test(browser.contentDocument.readyState)) {
  await new Promise(resolve =>
    browser.contentWindow.addEventListener("DOMContentLoaded", resolve, {
      once: true,
    })
  );
}
```

Comment 15

[Magnus Melin [:mkmelin]]

Yes that's nicer.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5df68d3ea93c
allow context menu for Thunderbird's about:addons. r=darktrojan