Open Bug 1589535 Opened 6 years ago Updated 3 years ago

Blocklist entries for add-ons include repetitive reasons

Categories

(Toolkit :: Blocklist Implementation, enhancement)

Product:
Toolkit
Component:
Blocklist Implementation
Type:
enhancement

Tracking

()

People

(Reporter: Gijs, Unassigned)

References

Details

We block add-ons for a pretty standard set of reasons. This means that the "why" bits in the blocklist records which are included in the local indexeddb database get duplicated a lot. This feels like a waste of space. Perhaps we can use enums, or omit them from the client-side stuff? (I don't think we ever use this text in the client, and there's certainly no l10n infrastructure...)

Andreas / Mathieu, thoughts?

Flags: needinfo?(mathieu)
Flags: needinfo?(awagner)

It's right that we have canned copy for the common use case. However, sometimes we are using custom copy, depending on the actual blocklist reason.

Also, there might be larger changes coming to the blocklist, so I am not sure it's worth the effort.

Flags: needinfo?(awagner)

We only expose the "Why" here: https://blocked.cdn.mozilla.net/. I don't know if that's worth keeping, though. IIRC, we now link to a general SUMO page from the blocklisting UI.

Maybe we can avoid serving this data on the remote settings endpoint and including it in the json dumps, if the client doesn't use it... that'd help a bit in terms of bandwidth + disk usage as well as processing time on the client.

It's not possible to have them in the JSON dump but not on the server though. Client and server data should match.

But if we can replace the Why paragraph by a generic link on the blocked pages website, then we can remove it from the records.

From what I could try quickly, the whole collection size would go from 657K to 566K (-15%)

Flags: needinfo?(mathieu)

Blocklist v3 won't have the reason. Would that fully fix this bug, or do you also want to account for non-addon blocklists before closing this bug?

Depends on: blocklist-v3

(In reply to Rob Wu [:robwu] from comment #5)

Blocklist v3 won't have the reason. Would that fully fix this bug, or do you also want to account for non-addon blocklists before closing this bug?

Plugins is going away later this year, and gfx is comparably tiny, so I don't think we need to worry about those.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.