1589543 - URL bar focus ring doesn't appear while input is hovered

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[bgstandaert]

Attachment: urlbar-bug.mp4

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

1. Open the latest nightly (or dev edition 71) on macOS.
2. Make sure the megabar is disabled.
3. Focus the URL bar with the mouse.

Actual results:

The focus ring doesn't appear until the mouse is moved off of the input.

Mozregression won't provide an exact regression range; this is the closest I could get: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6660bc0d1b23ae45dc3c952b6e21c0335e9739e9&tochange=c5e6477c3a245a97d4c3cdd5d3e406f8abaf94ad.

Expected results:

A blue focus ring should appear around the input as soon as it is focused.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Drew Willcoxon :adw]

I see this too. I don't know if it was intentional or not, but I'm assuming it's related to recent megabar work. In the pushlog, there are two bugs that look suspicious, bug 1587800 and bug 1588084.

Comment 3

[Drew Willcoxon :adw]

I narrowed it down to bug 1587800.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1589543 - Let :hover not override [focused] styling. r=adw,mak

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/014c61389f0b
Let :hover not override [focused] styling. r=mak

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/014c61389f0b