Closed Bug 1589626 Opened 2 years ago Closed 2 years ago

LSNG: Add a check for null quota object

Categories

(Core :: Storage: localStorage & sessionStorage, defect, P1)

Product:
Core
Component:
Storage: localStorage & sessionStorage
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- disabled
firefox67 --- disabled
firefox68 --- disabled
firefox69 --- disabled
firefox70 + disabled
firefox71 --- fixed

People

(Reporter: janv, Assigned: janv)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

Bug 1589626 - LSNG: Add a check for null quota object; r=ttung
47 bytes, text/x-phabricator-request
Details | Review

mozilla::dom::quota::QuotaObject::LockedMaybeUpdateSize started showing up in the crash stats. I believe it's related to a mismatch between base domain computed by MozURL and nsIPrincipal. I think we should rather fail datastore preparation instead of crashing if this happens, at least for now.

Type: defect → task
Summary: LSNG: Check for null quota object → LSNG: Add a check for null quota object
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c36aa74864ff
LSNG: Add a check for null quota object; r=ttung

https://hg.mozilla.org/mozilla-central/rev/c36aa74864ff

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Keywords: crash

In early crash results from 70 release, this is in the top 10 crash signatures.

Tracking to see what the volume looks like after a bit more time on release.

tracking-firefox70: --- → +

I guess this bug is moot for Fx70 now given bug 1592136.

You need to log in before you can comment on or make changes to this bug.