1589695 - The saved logins are not displayed in the “Login List” after signing in to Sync through the “Firefox Account” avatar, if the “about:logins” page was previously moved to a new window

Status: NEW

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: Sync.mp4

[Notes]:
After following the steps from below we encountered the following behaviors:

• If we create a new login, different from the ones that are already synced with the “Firefox Account”, the “An entry for <website address> with that username already exists” error message is displayed.
• If you choose to save a login from a website, the saved login is not recognized and is not displayed in the “Login List”.
• Also, the logins imported from other browsers are not displayed in the “Login List”.

[Affected versions]:

• Latest Firefox Nightly 71.0a1 (Build ID: 20191017215425) (64-bit)
• Firefox R-C 70.0 (Build ID: 20191016161957)

[Affected Platforms]:

• Windows 10 x64
• Mac 10.14
• Ubuntu 16.04 x64.

[Prerequisites]:

• Have a new Firefox profile without saved logins.
• Have a FxA account with multiple saved logins.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to "about:logins" page.
3. Move the “about:logins” tab to new window.
4. Click the “Firefox Account” toolbar button and log in with valid FxA credentials.
5. Focus the "about:logins" tab after the sync action is complete.
6. Observe the “Login List”.

[Expected result]:

• The saved logins are correctly displayed in the “Login List”

[Actual result]:

• Nothing happens. The saved logins are not displayed in the “Login List”.

[Additional Notes]:

• This issue is also reproducible after sing in to Sync through the Hamburger menu.
• This issue is not reproducible when signing in to Sync through the “Sign in to Sync” button from the “about:logins” page.
• The issue is no longer reproducible after refreshing the page.
• Attached a screen recording with the issue.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Sounds like an edge case, I don't think this is a priority to fix in 70. Let me know if you disagree once this is triaged by the team though.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

We store a list of "subscribers" in AboutLoginsParent.jsm that get notified of updates to storage changes. When a tab is detached, the subscribers list will contain the old target. This old target is thrown away and replaced with the new target when an event happens on the page that messages the parent JSM. In these STR, there is no event happening on the page after detaching, thus the subscribers list still contains the stale target.

To fix this bug, we should have AboutLoginsParent.jsm update their list of subscribers when a tab is detached. We could use pagehide/pageshow from the aboutLogins.js side to do this (though that would fire when the selected tab changes without a detach), or we could use "TabBrowserInserted".

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

This is quite an edge case since the user has to sign in to Firefox using the button in the browser toolbar. Any action on the page such as creating, deleting, opening a site, or clicking the Accounts button within the page will cause the future synced logins to load properly. I'll change this to 70-wontfix.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 5

[Matthew N. [:MattN]]

Mass removing [skyline] and [passwords:management] from about:logins bugs which are no longer useful.