158976 - Offline:`Work Offline' menu item should be checked when offline

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Matthew T (active 1999-2002)]

To reproduce:
1.  Open Navigator's `File' menu.
2.  Choose `Work Offline'.
3.  Open the `File' menu again.

What you see:
*   `Work Online'.

What you should see:
*   `/ Work Offline'.

If a toggle is presented as `Foo On Bar' and `Foo Off Bar', it is much harder to
see and understand from the wording what the current mode is. Such wording
should only be used, therefore, when (1) the current mode is very obvious, and
(2) the item is very rarely used. Examples of this include `{Show|Hide}
Balloons' in the Help menu of Mac OS 7~9, and `{Show|Hide} the Office Assistant'
in Microsoft Office. Examples do *not* include the offline mode in any browser,
where the current mode is much less obvious.

Bug occurs in:
*   build 2002072103, Mac OS 9.2.2

Does not occur in:
*   Microsoft Internet Explorer 5.1.4
*   iCab 2.7.1
*   Opera 5.0b5

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

blake, could you sr this patch here? Thanks

Comment 3

[Blake Ross]

Comment on attachment 92638 [details] [diff] [review]
patch

This patch is not technically correct, since the toolbar icon also observes the
broadcaster, so you're setting checked on that true.  You really just want to
set checked on the menuitem.  But since you didn't really cause that problem,
I'll sr (but it'd be good if you fixed that).  Move type="checkbox" to the
broadcaster.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

new patch with requested changes.
I use if (menuItem) because there are windows w/ a online/offline item in the
statusbar but without menus (message search, for example)

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

new patch with requested changes.
I use if (menuItem) because there are windows w/ a online/offline item in the
statusbar but without menus (message search, for example)

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

new patch with requested changes.
I use if (menuItem) because there are windows w/ a online/offline item in the
statusbar but without menus (message search, for example)

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

new patch with requested changes.
I use if (menuItem) because there are windows w/ a online/offline item in the
statusbar but without menus (message search, for example)

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

new patch with requested changes.
I use if (menuItem) because there are windows w/ a online/offline item in the
statusbar but without menus (message search, for example)

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

arrrrrg I blame Mozilla for attaching this five times or so, sorry for the spam

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 92708 [details] [diff] [review]
patch v2

transferring r=timeless sr=blake

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed

Comment 12

[grylchan]

I want to double check that this is correct behavior:
  -when offline : then wif I go to file|offline|work offline
                  I should see a check mark
  -when online: no check mark

Is this correct?

Using 
2002-09-10-08-trunk nt 4.0
2002091008 trunk Mac OS 10.1.5
2002091108 trnk linux 2.2

I am seeing inconsistency with the checkmark in the menu item 'work offline'.


Some test cases:
  -Initially both browser and Mail 'work offline' menu items are unchecked
   1)
     a) use browser menu item to go offline
     b) go online via mail menu item
     result: browser menu item stil has check mark but mail menu item
             doesn't. The converse of this test case also applies.
   2)
    a) Use mail menu item to go offline
    b) both browser and mail menu item show checkmark
    c) go online via offline icon in mail (lower right hand corner)
    result: both menu items still show check marks

There are more scenarios like this. Other windows that you can go
offline via icon include: seperate mail window, composer, addressbook.

I think this all needs to be fixed.

I am going to reopen this bug.

     

Comment 13

[grylchan]

Other test cases
  -going offline via profile mgr (this seemed to work fine)
  -go offline in mail via menu but click "GetMsgs" button
   to go back online

The bug for offline icon not working in other windows
is bug 80970.

Comment 14

[jglick]

FYI, this bug is a dup of Bug 117036, which was marked WONTFIX. Per Mozilla 
guidelines, (http://www.mozilla.org/get-involved.html) bugs that affect 
Mail/News need to go through one of the Mail/News module owners, sspitzer, 
mscott, bienvenu. Mail/News bugs that involve UI, should go through Mail/News UI 
module owner, jglick, as well. Thanks.

Comment 15

[(not reading, please use [e-mail] instead)]

jglick, if this doesn't match our spec, let me know.

I'll back it out.

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

-> default owner as the rest of my ui patches.

jglick, sorry for not contacting you about this change. I was not really aware
that this would touch mailnews as well (the menu there looks pretty different).

anyway, I have stopped working on mozilla ui. let the default owner make a
decision about this.

Comment 17

[grylchan]

*** Bug 176499 has been marked as a duplicate of this bug. ***

Comment 18

[Wesha]

Please take a look at bug 179728.

I bet it's caused by this piece of the patch:
--------------------------------------------------------
+      if (menuItem)
+        broadcaster.removeAttribute("checked");
--------------------------------------------------------

Should be (I think):
--------------------------------------------------------
+      if (menuItem)
+        menuItem.removeAttribute("checked");
--------------------------------------------------------

Comment 19

[grylchan]

Jennifer, Blake and Seth,

I've seen some bugs and or discussion about this:
see bug 179728, bug 117036. Maybe more bugs out there.

I am assuming we want to go back to the old way?
If so, Whenever Seth or Blake get some free time,
do we want them to back the change out and go back to old way?

I realize this probably low on their priority list. If I
see more bugs on this not working properly, I will dupe
against this bug. No hurry.

Comment 20

[grylchan]

*** Bug 180853 has been marked as a duplicate of this bug. ***

Comment 21

[grylchan]

nominating for nsbeta1 to switch back to the old way..
assuming seth/jennifer don't have objections

Comment 22

[timeless]

jglick et al, you need to get approval from blake or ben or some browser owner
before you make changes that affect the browser side. so don't just go rampaging
the other way.

Comment 23

[grylchan]

That's Cool. Both Browser and Mail modules owners should decide
what's the best way to handle this. I'm nominating on the Mail point
of view.

But using commercial trunk
rv:1.3a Gecko/20021204 on XP

In browser: if I do file|workoffline, i see checkmark.
But if I go online via the offline widget in lower right handcorner,
the workoffline menu item is still checked.

Comment 24

[Wesha]

gchan: see comment 18.

Comment 25

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 26

[[e-mail]]

Attachment: Turned Wesha's comment 18 into a patch

Obsoleting existing patches as they are obsolete or checked in.

See bug 179728 for an alternative approach.

Comment 27

[(not reading, please use [e-mail] instead)]

> See bug #179728 for an alternative approach.

neil, will your fix in bug #179728 address this bug completely?  If so, let's
mark it a dup and drive in your fix for that bug.

Comment 28

[(not reading, please use [e-mail] instead)]

from neil:

"Technically this bug should have been resolved fixed, as a near-perfect fix was
checked in, and bug 179728 is merely a regression"

I'll let him close the bug out.

Comment 29

[[e-mail]]

Well, either this or bug 179728 needs to be resolved - I picked this one :-)

Comment 30

[benc]

VERIFIED: Mac OS X, Mozill 1.6b.

Also, I resolved bug 176499, which had become a Mac-only problem where the menu
item was simply not flipping back and forth.