Closed Bug 1589864 Opened 3 months ago Closed 3 months ago

Optionally copy over prefs when starting the browser toolbox

Categories

(DevTools :: Framework, defect)

defect
Not set

Tracking

(firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(1 file)

Browser toolbox preferences have some strange semantics. The first time the browser toolbox is opened (on a machine I think, but maybe for a given profile), a new profile is created for the toolbox and the currently profile's preferences are copied over to it. When the browser toolbox is opened at later times, its preferences are left unchanged. This is problematic for several reasons:

  • It's pretty confusing when the browser toolbox is opened and its behavior doesn't match up with the original firefox instance's preferences.

  • There isn't an easy way to change the browser toolbox preferences. On macOS I have to right click the toolbox process in the dock, select "New Window", then go to about:config in that new window to modify the prefs.

  • This allows mochitests to interact with each other. If several mochitests in a test run try to open the browser toolbox with different sets of preferences, the toolbox will only use the preferences from the first test which opened the toolbox. This is preventing bug 1444064 from landing.

The best thing to do here is I think to always copy over the current profile's preferences to the browser toolbox profile when opening the browser toolbox. This is easy to do and addresses all of the above points.

Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8fbc32922a19
Copy over prefs when starting the browser toolbox, r=ochameau.

To update the title of this bug, the patch which landed only optionally updates the preferences when starting the browser toolbox, which will allow tests to work independently from each other. I'm hoping we can update the preferences all the time, but more work is needed, see D49829.

Summary: Copy over prefs when starting the browser toolbox → Optionally copy over prefs when starting the browser toolbox
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.