1590020 - Disable allCapitalsString parser

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Matjaz Horvat [:mathjazz]]

Attachment: photo5863987423132889444.jpg

Translate.Next introduced the ability to mark placeables in translations with the same algorithm as in source strings.

Since the allCapitalsString parser detects CAPITALS as placeables if they only consist of ASCII-characters, it doesn't work too well in translations, which often contain other characters as well. See the attachment to see how only half of the word is marked as placeable.

There are other issues with the allCapitalsString parser, namely detecting false positives (all examples in the screenshot).

We should drop marking CAPITALS as placeables.

Alternatives: only mark CAPITALS when they are surrounded with whitespace/punctuation.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Looking at these examples, should capital words even be marked? As far as I understand them, placeables should be terms that do not need to be translated, and that is not the case for any of these. If that is the case, I'd advocate to simply remove that parser.

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Adrian Gaudebert [:adrian] from comment #1)

Looking at these examples, should capital words even be marked? As far as I understand them, placeables should be terms that do not need to be translated, and that is not the case for any of these. If that is the case, I'd advocate to simply remove that parser.

+1 on removing it. That might be useful in some edge cases, were you want to copy an acronym (e.g. URL), but in the majority of cases we end up with untranslated content because of the confusion created by this.

Comment 3

[kathiekim95]

Hello @Adrian, concerning this bug fix, should I work on removing the parser or work on stop marking CAPITALS as placeables.

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

This bug is about removing the allCapitalsString parser entirely from the code base. You should search for all places where it appears, remove it, and then make sure capital words are not matched anymore in the UI and that all tests pass.

Comment 5

[kathiekim95]

Thanks for clarity @Adrian

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1447

Comment 7

[Matjaz Horvat [:mathjazz]]

https://github.com/mozilla/pontoon/commit/896feb1d4ffe08688f7756f436da2fc903bc5ce4