1590029 - Request blocking toolbar button isn't available

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

When Request Blocking is enabled (devtools.netmonitor.features.requestBlocking), the Request Blocking button does not appear in the toolbars in two-toolbar mode (e.g. when docked to the side).

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

David, can you please look at this. It's simple to fix, the button should be rendered around this place too:
https://searchfox.org/mozilla-central/rev/d7537a9cd2974efa45141d974e5fc7c727f1a78f/devtools/client/netmonitor/src/components/Toolbar.js#563

Honza

Comment 2

[David Walsh :davidwalsh]

Attachment: Bug 1590029 - Show blocking button in multiple row view r=Honza

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02d95bdf2f74
Show blocking button in multiple row view r=Honza

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/02d95bdf2f74

Comment 5

[Cristian Fogel [:cfogel]]

Confirmed issue with 72.0a1 (2019-10-21) on Windows 10 .
Verified fix with 72.0a1 (2019-10-27) on Windows 10, macOS 10.14, Ubuntu 16.04.

Comment 6

[:Harald Kirschner :digitarald]

Comment on attachment 9102979 [details]
Bug 1590029 - Show blocking button in multiple row view r=Honza

Beta/Release Uplift Approval Request

• User impact if declined: Request blocking icon disappears in right-docked mode
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 1-liner fix for the toolbar icon.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9102979 [details]
Bug 1590029 - Show blocking button in multiple row view r=Honza

Low risk devtools polish fix, uplift approved for 71 beta 8, thanks.

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a26c61e15f3f

Comment 9

[Cristian Fogel [:cfogel]]

Quick check on 71.0b8 as well. Button appears on all above mentioned platforms.