Closed Bug 1590029 Opened 3 months ago Closed 3 months ago

Request blocking toolbar button isn't available

Categories

(DevTools :: Netmonitor, defect, P2)

All
Unspecified
defect

Tracking

(firefox71 verified, firefox72 verified)

VERIFIED FIXED
Firefox 72
Tracking Status
firefox71 --- verified
firefox72 --- verified

People

(Reporter: Honza, Assigned: davidwalsh)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image image.png

When Request Blocking is enabled (devtools.netmonitor.features.requestBlocking), the Request Blocking button does not appear in the toolbars in two-toolbar mode (e.g. when docked to the side).

Honza

David, can you please look at this. It's simple to fix, the button should be rendered around this place too:
https://searchfox.org/mozilla-central/rev/d7537a9cd2974efa45141d974e5fc7c727f1a78f/devtools/client/netmonitor/src/components/Toolbar.js#563

Honza

Flags: needinfo?(dwalsh)
Priority: -- → P2
Assignee: nobody → dwalsh
Status: NEW → ASSIGNED
Flags: needinfo?(dwalsh)
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02d95bdf2f74
Show blocking button in multiple row view r=Honza
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Confirmed issue with 72.0a1 (2019-10-21) on Windows 10 .
Verified fix with 72.0a1 (2019-10-27) on Windows 10, macOS 10.14, Ubuntu 16.04.

Status: RESOLVED → VERIFIED

Comment on attachment 9102979 [details]
Bug 1590029 - Show blocking button in multiple row view r=Honza

Beta/Release Uplift Approval Request

  • User impact if declined: Request blocking icon disappears in right-docked mode
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): 1-liner fix for the toolbar icon.
  • String changes made/needed:
Attachment #9102979 - Flags: approval-mozilla-beta?

Comment on attachment 9102979 [details]
Bug 1590029 - Show blocking button in multiple row view r=Honza

Low risk devtools polish fix, uplift approved for 71 beta 8, thanks.

Attachment #9102979 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Quick check on 71.0b8 as well. Button appears on all above mentioned platforms.

Hardware: Unspecified → All
You need to log in before you can comment on or make changes to this bug.