1590034 - Use MOZ_CRASH_UNSAFE_PRINTF in AutoEnterOOMUnsafeRegion::crash

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jan de Mooij [:jandem]]

This will make it easier to see where the crashes in bug 1584232 are coming from. It also simplifies the code.

Comment 1

[Jan de Mooij [:jandem]]

Are the fuzzers okay with this:

Assertion failure: [unhandlable oom] Foo
Hit MOZ_CRASH() at js/src/vm/JSContext.cpp:1519

Changing to:

Hit MOZ_CRASH([unhandlable oom] Foo) at js/src/vm/JSContext.cpp:1516

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1590034 - Use MOZ_CRASH_UNSAFE in AutoEnterOOMUnsafeRegion::crash. r?jonco!

It's simpler and this way the |reason| string will be available on crash-stats.

Comment 3

[Christian Holler (:decoder)]

MOZ_CRASH messages only print in debug builds, so this is going to be a problem.

We could make MOZ_CRASH print its message in debug or fuzzing builds, I wanted to make this change anyway. Now we have another reason to do so. I'll file a bug.

Comment 4

[Christian Holler (:decoder)]

Oh I misread, you want to use MOZ_CRASH_UNSAFE_PRINTF. In that case, it should work. But would it be easier for you to use MOZ_CRASH instead if we want to make the print change anyway for fuzzing builds?

Comment 5

[Jan de Mooij [:jandem]]

(In reply to Christian Holler (:decoder) from comment #3)

MOZ_CRASH messages only print in debug builds, so this is going to be a problem.

Yeah, I just fixed that in the patch, because we also need this printing in opt builds for the jit-test harness and those shell builds are not all fuzzing builds...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb2c1e0f98d0
Use MOZ_CRASH_UNSAFE in AutoEnterOOMUnsafeRegion::crash. r=jonco

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bb2c1e0f98d0