Open Bug 1590037 Opened 5 years ago Updated 2 years ago

mozlint outputs absolute paths for source-test-mozlint-license

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Tracking

(Not tracked)

People

(Reporter: bastien, Unassigned, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

As Bug 1568484 removed absolute paths output from mozlint, the licence checker should also output relative paths.

But a recent licence check task found an issue and reported it using the full path

Mentor: sledru
Keywords: good-first-bug
Whiteboard: [lang=python]

(In reply to Bastien Abadie [:bastien] from comment #0)

As Bug 1568484 removed absolute paths output from mozlint, the licence checker should also output relative paths.

But a recent licence check task found an issue and reported it using the full path

can you please attach a file with this comment which contains the output (or whatever the links contained) as the links are not working (atleast not for me).

(In reply to Bastien Abadie [:bastien] from comment #0)

As Bug 1568484 removed absolute paths output from mozlint, the licence checker should also output relative paths.

But a recent licence check task found an issue and reported it using the full path

[:bastien], can you provide the links again as the previous ones don't seem to work? Also, I would like to figure something out and give it a try, so any other information regarding the bug will be useful!

[:Sylvestre], I just realized Bastien Abadie's profile is disabled, and cannot request information from him.
Can you provide the links (as the ones given in the description don't work) and any other information useful to start over the bug and I can give it a try?

Flags: needinfo?(sledru)

(In reply to Nirmay Dhruv [:nirmay] from comment #3)

[:Sylvestre], I just realized Bastien Abadie's profile is disabled, and cannot request information from him.
Can you provide the links (as the ones given in the description don't work) and any other information useful to start over the bug and I can give it a try?

Thanks for pointing out that Bastien Abadie's account is disabled.

Andi might be able to help. Sorry for the crazy latency!

Flags: needinfo?(sledru) → needinfo?(bpostelnicu)

Please look here for the definition yml for the files that are excluded.
The implementation for the linter resides here.

Flags: needinfo?(bpostelnicu)

Is this issue still open to working? I would like to work.

Product: Firefox Build System → Developer Infrastructure

Hi, I am getting started with Open Source. I want to work on this issue. Would u assign this to me? And let me know how I start to work on it?

the bug will be assigned to you once you submitted the patch.
for the doc:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
and comment #6 should be enough

Okay, I am getting started right away.

what build type should I choose while running bootstrap.py?

Severity: normal normal → S3 S3
You need to log in before you can comment on or make changes to this bug.