Closed Bug 1590042 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19802 - Use a new temporary directory for manifest generation in CI

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19802 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19802
Details from upstream follow.

Philip Jägenstedt <philip@foolip.org> wrote:

Use a new temporary directory for manifest generation in CI

In https://github.com/web-platform-tests/wpt/pull/19580 retry for
manifest generation was introduced, to make it more robust in case of
network errors or the GitHub search API not indexing the merged PR
fast enough.

However, an accidental commit to master showed that this won't work:
https://github.com/web-platform-tests/wpt/runs/265191690

It first failed with "No PR found for 9e1d0a26f155ccb088d342b0036e535d033423c1"
because there was no PR, just a direct push to master. Retries then
failed with "File exists: '/home/runner/meta'".

Use a new temporary directory every time to deal with this. Don't
attempt to remove the directory when done as this script is run in a
CI system where all state is thrown away on completion.

PR 19802 applied with additional changes from upstream: ca1a7a206f4ff0f8de1169b183b3b2474850a7c0, be08de67a0b21e800cc263e319aa4f17034bae53, 2d84e4d2cc6d881d0abd7d968a7709a18b309f3a, 805c75b7fc049f0f3d332f842f688db46533298f, 14f032147ff36be6e6123a4cf4c0d365fe564e57, f60b9f7ec3da5f7de0cb469b05be4d8886a06b98
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fb5eab04660
[wpt PR 19802] - Use a new temporary directory for manifest generation in CI, a=testonly
Result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/9fb5eab04660

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.