Closed Bug 1590047 Opened 6 months ago Closed 6 months ago

When inserting a link, despite filling in the details, the OK button isn't shown active

Categories

(Thunderbird :: Message Compose Window, defect)

defect
Not set

Tracking

(thunderbird71 fixed, thunderbird72 fixed)

RESOLVED FIXED
Thunderbird 72.0
Tracking Status
thunderbird71 --- fixed
thunderbird72 --- fixed

People

(Reporter: jorgk-bmo, Assigned: khushil324)

Details

Attachments

(1 file)

When inserting a link, despite filling in the details, the OK button isn't shown active.

It becomes active if you focus the main window and then return to the dialogue. Seen on TB 71 trunk.

Maybe something for Khushil to look into.

Flags: needinfo?(khushil324)
Assignee: nobody → khushil324
Flags: needinfo?(khushil324)

oninput is necessary as we want to check when we are entering each character.

Attachment #9103192 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9103192 [details] [diff] [review]
Bug-1590047_insert-link-dialog-editor-fix.patch

That does the trick, thanks. In the future, can you please supply your patches with 8 lines of context. Put this into mercurial.ini:
[diff]
git = 1
showfunc = 1
unified = 8
Attachment #9103192 - Flags: review?(mkmelin+mozilla)
Attachment #9103192 - Flags: review+
Attachment #9103192 - Flags: approval-comm-beta+
Target Milestone: --- → Thunderbird 72.0

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/87970d487593
Make OK button active when filling in the link in EdLinkProps.xul. r=jorgk DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED

(In reply to Jorg K (GMT+2) from comment #2)

That does the trick, thanks. In the future, can you please supply your
patches with 8 lines of context. Put this into mercurial.ini:
[diff]
git = 1
showfunc = 1
unified = 8

Sure.

Not a big issue, but it makes comparing patches easier. Thanks for the quick attention BTW!

You need to log in before you can comment on or make changes to this bug.