1590059 - "Search in files..." result header text overflows when wrapped on two lines

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Florens Verschelde :fvsch]

Attachment: search-in-files-result-header.png

Comment 1

[Florens Verschelde :fvsch]

So in bug 1588294 I removed the white-space: nowrap; text-overflow: ellipsis;, used a min-height instead of height, so that the header would grow taller if the text wrapped. It worked in my tests at the time, but doesn't seem to actually work in practice.

I'm stumped by this rendering issue. The header should grow taller.
Or maybe I'm not understanding something specific about Flexbox, or about about the very specific combination of display: grid, display: contents and display: flex we're using here.

My proposed fix is to restore the "single line, ellipsis if it overflows" behavior we had before.

Comment 2

[Florens Verschelde :fvsch]

Attachment: Bug 1590059 - Stop search result header text from overflowing its container; r=davidwalsh

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e85f7fb21f6
Stop search result header text from overflowing its container; r=davidwalsh

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1e85f7fb21f6