Closed Bug 1590059 Opened 2 years ago Closed 2 years ago

"Search in files..." result header text overflows when wrapped on two lines

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: fvsch, Assigned: fvsch)

References

(Regression)

Details

Attachments

(2 files)

No description provided.

So in bug 1588294 I removed the white-space: nowrap; text-overflow: ellipsis;, used a min-height instead of height, so that the header would grow taller if the text wrapped. It worked in my tests at the time, but doesn't seem to actually work in practice.

I'm stumped by this rendering issue. The header should grow taller.
Or maybe I'm not understanding something specific about Flexbox, or about about the very specific combination of display: grid, display: contents and display: flex we're using here.

My proposed fix is to restore the "single line, ellipsis if it overflows" behavior we had before.

Assignee: nobody → florens
Status: NEW → ASSIGNED
Regressed by: 1588294
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e85f7fb21f6
Stop search result header text from overflowing its container; r=davidwalsh
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
QA Whiteboard: [qa-72b-p2]
You need to log in before you can comment on or make changes to this bug.