Closed Bug 1590093 Opened 2 years ago Closed 2 years ago

3% regression on console opening

Categories

(DevTools :: Console, defect, P2)

defect

Tracking

(firefox-esr68 unaffected, firefox70 unaffected, firefox71 fixed, firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- fixed
firefox72 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

DAMP reports a small regression due to the settings button probably loading too much file eagerly

Priority: -- → P2

We try to lazy load all the things we know we might
not need directly when opening the console.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a516296693b
Lazy load console components. r=Honza.

Not using the right condition for rendering the notificationBox (+ reverse search test failures).
New patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdf5fcff470c846f9039abf23599710de8ef20e9

Flags: needinfo?(nchevobbe)
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a369fbf2c7b
Lazy load console components. r=Honza.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(nchevobbe)

Comment on attachment 9104626 [details]
Bug 1590093 - Lazy load console components. r=Honza.

Beta/Release Uplift Approval Request

  • User impact if declined: Perf regression when opening the console
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Some modules are now lazy loaded. The console tests should have caught any issue that might have occured
  • String changes made/needed:
Flags: needinfo?(nchevobbe)
Attachment #9104626 - Flags: approval-mozilla-beta?

Comment on attachment 9104626 [details]
Bug 1590093 - Lazy load console components. r=Honza.

Low risk fix for a perf regression in devtools, uplift approved for 71 beta 7, thanks.

Attachment #9104626 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.