1590093 - 3% regression on console opening

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

DAMP reports a small regression due to the settings button probably loading too much file eagerly

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1590093 - Lazy load console components. r=Honza.

We try to lazy load all the things we know we might
not need directly when opening the console.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a516296693b
Lazy load console components. r=Honza.

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset 0a516296693b (bug 1590093) for causing browser_jsterm_selfxss.js to permafail

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=273253331&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=0a516296693bb8b221744bae054419be6f2510c2&searchStr=dt

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=273253331&fromchange=26eaf3f0479b535b44156377ab328c79b48237ac&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-devtools-chrome-e10s-2%2Cm%28dt2%29

backout: https://hg.mozilla.org/integration/autoland/rev/d48c19be70fea3f669d456f1f8920a8096c8ae00

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Not using the right condition for rendering the notificationBox (+ reverse search test failures).
New patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdf5fcff470c846f9039abf23599710de8ef20e9

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a369fbf2c7b
Lazy load console components. r=Honza.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8a369fbf2c7b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9104626 [details]
Bug 1590093 - Lazy load console components. r=Honza.

Beta/Release Uplift Approval Request

• User impact if declined: Perf regression when opening the console
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Some modules are now lazy loaded. The console tests should have caught any issue that might have occured
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9104626 [details]
Bug 1590093 - Lazy load console components. r=Honza.

Low risk fix for a perf regression in devtools, uplift approved for 71 beta 7, thanks.

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/42799e05eaeb