1590115 - Profiler not reading local build symbols

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[Julien Wajsberg [:julienw]]

+++ This bug was initially created as a clone of Bug #1588086 +++

This is still not fixed in the case of a local build using the popup.
The problem is that in [1] that function doesn't exist :(

[1] https://searchfox.org/mozilla-central/rev/d7537a9cd2974efa45141d974e5fc7c727f1a78f/devtools/client/performance-new/popup/initializer.js#41

Comment 1

[Julien Wajsberg [:julienw]]

I think bug 1587117 regressed this actually, not bug 1581975. The function was existing in bug 1581975 but got then removed in bug 1587117.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Bug 1590115 - Add getSymbolsFromThisBrowser back

This function is used in several locations and at least two files, so
it's useful to have it exist as a named and exported function.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25b0f8545d46
Add getSymbolsFromThisBrowser back r=canaltinova

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/25b0f8545d46

Comment 5

[Julien Cristau [:jcristau]]

Is this worth fixing in 71?

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 9103012 [details]
Bug 1590115 - Add getSymbolsFromThisBrowser back

Beta/Release Uplift Approval Request

• User impact if declined: not possible to get the symbols for native code when profiling a local build
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is basically reverting a small part of an earlier patch. Also this code isn't used by end users but rather gecko developers.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9103012 [details]
Bug 1590115 - Add getSymbolsFromThisBrowser back

Low risk of regression to users, uplift approved for 71 beta 4, thanks.

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/c9fc9482d2a9