1590178 - Figure out a way to make xul:splitter work with non-xul-flexbox siblings, or make a replacement widget that does

Status: NEW

(Toolkit :: UI Widgets, task, P3)

Description

[Brian Grinstead [:bgrins]]

One of the challenges with getting XUL flexbox emulation functionally working is that splitters don't work with css flex siblings. They also wouldn't work with html element siblings even if they were -moz-box, since it relies on [width] and [height] attributes.

Comment 1

[Brian Grinstead [:bgrins]]

Neil, how difficult would it be to make <xul:splitter> work with HTML element siblings using css flexbox? I'm trying to figure out if we'd be better off writing something in JS (either an existing widget or writing something from scratch) or if the existing implementation could still be used.

Comment 2

[Neil Deakin]

The first step would be to be adjust to not read or write the width/height attributes and instead set the style width and height. The resizer does something like this.

There are also some calls to IsXULBoxFrame(). They probably could just be removed at that point.

Finally, nsSpliiterFrame would instead inherit from nsFlexContainerFrame (or something else). Since splitter doesn't have any special layout apart from an override to call UpdateState() in DoXULLayout that shouldn't be too difficult.

Comment 3

[Brendan Dahl [:bdahl]]

Attachment: Bug 1590178 - Support HTML element siblings in XUL splitter.

If the sibling element to a XUL splitter is an HTML element, set the CSS
width or height property instead of element attributes.