Closed Bug 1590201 Opened 5 years ago Closed 1 year ago

Implement Network.loadingFinished

Categories

(Remote Protocol :: CDP, enhancement, P3)

Product:
Remote Protocol
Component:
CDP
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: impossibus, Unassigned)

References

(
URL
)

Details

(Whiteboard: [puppeteer-beta2-mvp])

Example

{"method":"Network.loadingFinished","params":{"requestId":"1000019132.773","timestamp":519174.8424,"encodedDataLength":0,"shouldReportCorbBlocking":false}

It's of course frequently emitted during a gutenberg test run because of all the page loads involved.

In Puppeteer: https://github.com/GoogleChrome/puppeteer/blob/c2651c2b5cc888ebd0ca6be87063d9f98b9eb59c/lib/NetworkManager.js#L278

Whiteboard: [puppeteer-alp
Whiteboard: [puppeteer-alp → [puppeteer-alpha]

This event is setup in the constructor of the Page domain in Puppeteer. Puppeteer actually transforms it into NetworkManager.RequestFinished. See the link from Maja above.

Blocks: puppeteer-gutenberg

While this event is actually being emitted a lot nothing in Gutenberg seem to rely on it. It's only happening because the Network domain is enabled by default by Puppeteer, and as such network related events are flowing in.

No longer blocks: puppeteer-gutenberg
Priority: P2 → P3
Whiteboard: [puppeteer-alpha]
Whiteboard: [puppeteer-beta2-mvp]
Component: CDP: Network → CDP
Severity: normal → S3

We are not going to implement this event in our CDP implementation.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.