Closed Bug 1590206 Opened 1 year ago Closed 1 year ago

Set intl.multilingual.downloadEnabled default to true

Categories

(Thunderbird :: Preferences, enhancement)

enhancement
Not set
normal

Tracking

(thunderbird_esr6870+ fixed, thunderbird71 fixed, thunderbird72 fixed)

VERIFIED FIXED
Thunderbird 72.0
Tracking Status
thunderbird_esr68 70+ fixed
thunderbird71 --- fixed
thunderbird72 --- fixed

People

(Reporter: ovari123, Assigned: Paenglab)

References

Details

Attachments

(1 file, 2 obsolete files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

Please set intl.multilingual.downloadEnabled default to true

https://github.com/flathub/org.mozilla.Thunderbird/issues/90#issuecomment-544394095

Actual results:

Thunderbird does not automatically download and install dictionaries for languages available on the system

Expected results:

Automatically download and install dictionaries for languages available on the system

Component: Untriaged → Preferences

What about setting intl.multilingual.enabled you you can switch between languages in the advanced settings. Richard, do you have an opinion about this?

Flags: needinfo?(richard.marti)

Fx has it disabled on release : https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#1895

Question, what does mean "for languages available on the system"? Are this languages installed on TB or the OS? And does TB download the dictionaries automatically when the pref is enabled for the languages installed on the OS or only when the language is installed on TB?

Flags: needinfo?(richard.marti)

There was a misunderstanding on my part (elsewhere). Setting these prefs has nothing to do with dictionaries, only language packs. But we should still set the prefs on the release channel. It works there but not on beta or nightly.

(In reply to Richard Marti (:Paenglab) from comment #2)

Fx has it disabled on release : https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#1895

I see the code has "RELEASE_OR_BETA" - doesn't it mean ENABLED on release? This is what I see in latest stable FF release - this option is enabled by default.

You're right. I misread it.

Let's follow FF here. Richard, could you do a patch?

Like this?

Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9103651 - Flags: review?(jorgk)
Comment on attachment 9103651 [details] [diff] [review]
1590206-enable-multilingual-on-release.patch

I think so. I'd copy this line from M-C:
// ATN only serves language packs for release and beta versions.
Attachment #9103651 - Flags: review?(jorgk) → review+

Actually, before we go ahead, which language packs does ATN actually server? Release and beta? Or only release? Then we'd need to adjust the define accordingly.

Flags: needinfo?(sancus)

I think, Beta doesn't get them. But how would the define be? Does a RELEASE only exist?

It only serves release language packs for now.

Flags: needinfo?(sancus)

Does a RELEASE only exist?

I can't see one. So let's go with the patch and add:
// ATN only serves language packs for release (but there is no release-only define).

I've changed my mind a bit. Let's allow the multi-language UI everywhere. If we allow it for beta, Daily users (and developers) might as well get it, too. Some will be smart enough to find the language pack on the FTP site.

Attachment #9103728 - Flags: review+
Attachment #9103728 - Flags: approval-comm-esr68+
Attachment #9103728 - Flags: approval-comm-beta+
Attachment #9103651 - Attachment is obsolete: true

Changed comment wording a bit.

Attachment #9103728 - Attachment is obsolete: true
Attachment #9103729 - Flags: review+
Attachment #9103729 - Flags: approval-comm-esr68+
Attachment #9103729 - Flags: approval-comm-beta+

How can dictionaries be automatically downloaded and installed?

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1e088e620abe
Enable the multilingual pref, enable downloads on Release and Beta. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0

(In reply to Óvári from comment #15)

How can dictionaries be automatically downloaded and installed?

I don't think they can be, and I don't think this pref has anything to do with dictionaries either. Only language packs.

I don't think even Firefox has any automatic download for dictionaries.

Dictionaries can't no. Some dictionaries are not license compatible to do automatic installs. (Or at least grey zone)

I tried it in TB 71 and no additional languages were offered, but it works in TB 68 when setting the prefs manually.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.