1590206 - Set intl.multilingual.downloadEnabled default to true

Status: VERIFIED FIXED

(Thunderbird :: Preferences, enhancement)

Description

[Óvári]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

Please set intl.multilingual.downloadEnabled default to true

https://github.com/flathub/org.mozilla.Thunderbird/issues/90#issuecomment-544394095

Actual results:

Thunderbird does not automatically download and install dictionaries for languages available on the system

Expected results:

Automatically download and install dictionaries for languages available on the system

Comment 1

[Jorg K (CEST = GMT+2)]

What about setting intl.multilingual.enabled you you can switch between languages in the advanced settings. Richard, do you have an opinion about this?

Comment 2

[Richard Marti (:Paenglab)]

Fx has it disabled on release : https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#1895

Question, what does mean "for languages available on the system"? Are this languages installed on TB or the OS? And does TB download the dictionaries automatically when the pref is enabled for the languages installed on the OS or only when the language is installed on TB?

Comment 3

[Geoff Lankow (:darktrojan)]

There was a misunderstanding on my part (elsewhere). Setting these prefs has nothing to do with dictionaries, only language packs. But we should still set the prefs on the release channel. It works there but not on beta or nightly.

Comment 4

[Emerson Bernier]

(In reply to Richard Marti (:Paenglab) from comment #2)

Fx has it disabled on release : https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#1895

I see the code has "RELEASE_OR_BETA" - doesn't it mean ENABLED on release? This is what I see in latest stable FF release - this option is enabled by default.

Comment 5

[Richard Marti (:Paenglab)]

You're right. I misread it.

Comment 6

[Jorg K (CEST = GMT+2)]

Let's follow FF here. Richard, could you do a patch?

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1590206-enable-multilingual-on-release.patch

Like this?

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9103651 [details] [diff] [review]
1590206-enable-multilingual-on-release.patch

I think so. I'd copy this line from M-C:
// ATN only serves language packs for release and beta versions.

Comment 9

[Jorg K (CEST = GMT+2)]

Actually, before we go ahead, which language packs does ATN actually server? Release and beta? Or only release? Then we'd need to adjust the define accordingly.

Comment 10

[Richard Marti (:Paenglab)]

I think, Beta doesn't get them. But how would the define be? Does a RELEASE only exist?

Comment 11

[Andrei Hajdukewycz [:sancus]]

It only serves release language packs for now.

Comment 12

[Jorg K (CEST = GMT+2)]

Does a RELEASE only exist?

I can't see one. So let's go with the patch and add:
// ATN only serves language packs for release (but there is no release-only define).

Comment 13

[Jorg K (CEST = GMT+2)]

Attachment: 1590206-enable-multilingual-on-release.patch

I've changed my mind a bit. Let's allow the multi-language UI everywhere. If we allow it for beta, Daily users (and developers) might as well get it, too. Some will be smart enough to find the language pack on the FTP site.

Comment 14

[Jorg K (CEST = GMT+2)]

Attachment: 1590206-enable-multilingual-on-release.patch

Changed comment wording a bit.

Comment 15

[Óvári]

How can dictionaries be automatically downloaded and installed?

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1e088e620abe
Enable the multilingual pref, enable downloads on Release and Beta. r=jorgk

Comment 17

[Andrei Hajdukewycz [:sancus]]

(In reply to Óvári from comment #15)

How can dictionaries be automatically downloaded and installed?

I don't think they can be, and I don't think this pref has anything to do with dictionaries either. Only language packs.

I don't think even Firefox has any automatic download for dictionaries.

Comment 18

[Magnus Melin [:mkmelin]]

Dictionaries can't no. Some dictionaries are not license compatible to do automatic installs. (Or at least grey zone)

Comment 19

[Jorg K (CEST = GMT+2)]

TB 71 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/ce4286eeff371105a995115d4e739e4effa165eb

Comment 20

[Jorg K (CEST = GMT+2)]

I tried it in TB 71 and no additional languages were offered, but it works in TB 68 when setting the prefs manually.

Comment 21

[Jorg K (CEST = GMT+2)]

TB 68.2.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/40e032529362d153a4206fbdacc54edd42caa59d