1590272 - [wpt-sync] Sync PR 19817 - Don't trigger :focus-visible matching if a meta-key was pressed.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19817 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19817
Details from upstream follow.

Alice Boxhall <[e-mail]> wrote:

Don't trigger :focus-visible matching if a meta-key was pressed.

Also, move UpdateHadKeyboardEvent() call into KeyboardEventManager::KeyEvent().

Happy to revert the latter change if folks don't like it, but it seemed logically consistent with e.g. gesture detection.

Bug: 920458
Change-Id: Ia423a0533325314ae4f83e619337b5a81af0f4c4

Reviewed-on: https://chromium-review.googlesource.com/1871715
WPT-Export-Revision: 0994b68341e4b406c4f154f8b8e6078118065612

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6115828166229d56f51dfecd77d772c120a44c43

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=63b9884a8781176a4cd15960ee21cacdef13b991

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Result changes from PR not available.

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Result changes from PR not available.

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Attachment: Bug 1590272 [wpt PR 19817] - Don't trigger :focus-visible matching if a meta-key was pressed., a=testonly

Automatic update from web-platform-tests
Don't trigger :focus-visible matching if a meta-key was pressed.

Also, move UpdateHadKeyboardEvent() call into KeyboardEventManager::KeyEvent().

Happy to revert the latter change if folks don't like it, but it seemed logically consistent with e.g. gesture detection.

Bug: 920458
Change-Id: Ia423a0533325314ae4f83e619337b5a81af0f4c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871715
Commit-Queue: Alice Boxhall <[e-mail]>
Reviewed-by: Kent Tamura <[e-mail]>
Cr-Commit-Position: refs/heads/master@{#709357}

--

wpt-commits: 69646ed085ad3e2295549c3ecf3f5caa9e4e1e9a
wpt-pr: 19817

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Result changes from PR not available.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e890da8a1411
[wpt PR 19817] - Don't trigger :focus-visible matching if a meta-key was pressed., a=testonly

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e890da8a1411