Closed Bug 1590272 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 19817 - Don't trigger :focus-visible matching if a meta-key was pressed.

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 19817 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19817
Details from upstream follow.

Alice Boxhall <aboxhall@chromium.org> wrote:

Don't trigger :focus-visible matching if a meta-key was pressed.

Also, move UpdateHadKeyboardEvent() call into KeyboardEventManager::KeyEvent().

Happy to revert the latter change if folks don't like it, but it seemed logically consistent with e.g. gesture detection.

Bug: 920458
Change-Id: Ia423a0533325314ae4f83e619337b5a81af0f4c4

Reviewed-on: https://chromium-review.googlesource.com/1871715
WPT-Export-Revision: 0994b68341e4b406c4f154f8b8e6078118065612

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Result changes from PR not available.
Result changes from PR not available.

Automatic update from web-platform-tests
Don't trigger :focus-visible matching if a meta-key was pressed.

Also, move UpdateHadKeyboardEvent() call into KeyboardEventManager::KeyEvent().

Happy to revert the latter change if folks don't like it, but it seemed logically consistent with e.g. gesture detection.

Bug: 920458
Change-Id: Ia423a0533325314ae4f83e619337b5a81af0f4c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871715
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709357}

--

wpt-commits: 69646ed085ad3e2295549c3ecf3f5caa9e4e1e9a
wpt-pr: 19817

Result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e890da8a1411
[wpt PR 19817] - Don't trigger :focus-visible matching if a meta-key was pressed., a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.