Closed
Bug 1590319
Opened 5 years ago
Closed 5 years ago
Revert async task queueing in MediaRecorder::Pause()/Resume()
Categories
(Core :: Audio/Video: Recording, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla72
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox70 | --- | unaffected |
firefox71 | --- | fixed |
firefox72 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
These were added per spec in bug 1514158, but it turns out no implementation is queuing tasks here.
We're also already looking into whether the spec should change around these algorithms: https://github.com/w3c/mediacapture-record/issues/131
The sane thing to do here would be to reverse to our old behavior wrt Pause() and Resume() (Stop() is not queueing a task yet) until the spec issues are resolved.
Assignee | ||
Updated•5 years ago
|
status-firefox70:
--- → unaffected
status-firefox71:
--- → affected
status-firefox72:
--- → affected
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → unaffected
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d6e5123eba18 Revert async task queueing in MediaRecorder::Pause()/Resume(). r=jib
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9103187 [details]
Bug 1590319 - Revert async task queueing in MediaRecorder::Pause()/Resume(). r?jib
Beta/Release Uplift Approval Request
- User impact if declined: We updated the implementation to be per spec in 71. At the same time there's a spec issue to change the spec to something close to our old behavior. It also happens that Chrome's implementation matches our old behavior and not the spec. To not flip-flop the behavior between 70-71-72 I'd like to uplift this to 71.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial, and matching old behavior.
- String changes made/needed:
Attachment #9103187 -
Flags: approval-mozilla-beta?
Comment 5•5 years ago
|
||
Comment on attachment 9103187 [details]
Bug 1590319 - Revert async task queueing in MediaRecorder::Pause()/Resume(). r?jib
Looks safe as we are getting back to 70 behaviour, uplift approved for 71 beta 4 thanks!
Attachment #9103187 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•5 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•