1590376 - Remove nsResizerFrame.cpp (resizer XUL element)

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Tim Nguyen :ntim]

This seems bound to the resizer XUL element, which no longer seems used:

https://searchfox.org/mozilla-central/search?q=%3Cresizer&path=
https://searchfox.org/mozilla-central/search?q=createXULElement%28%22resizer%22&path=
https://searchfox.org/mozilla-central/search?q=createElement%28%22resizer%22&path=
https://searchfox.org/mozilla-central/search?q=createElementNS%28%22http%3A%2F%2Fwww.mozilla.org%2Fkeymaster%2Fgatekeeper%2Fthere.is.only.xul%22%2C+%22resizer%22&path=

I don't see the frame being used elsewhere either: https://searchfox.org/mozilla-central/search?q=NS_NewResizerFrame&path=

Comment 1

[Mats Palmgren (inactive)]

I think it's still used by scroll frames:
https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/layout/generic/nsGfxScrollFrame.cpp#4922-4926
https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/layout/base/nsCSSFrameConstructor.cpp#4136
So I don't think we can remove it.

Comment 2

[Tim Nguyen :ntim]

Ah, good catch. It should probably be moved out of layout/xul and be de-XULed then, given that the <resizer> element is only used as anon content in resizable HTML elements. We should also be explicit about not allowing <resizer> in other cases too.

Comment 3

[Mats Palmgren (inactive)]

Attachment: Bug 1590376 part 1 - Add a XULResizerElement and move all nsResizerFrame's event handling code there. r=ntim,smaug

I'm mostly moving the code verbatim, but I excluded a few bits
that handled resizers inside menu popup frames, e.g.
https://searchfox.org/mozilla-central/rev/7bb1cc6abf6634b2a20f71935e1e519e73402b63/layout/xul/nsResizerFrame.cpp#165-170
I don't think we need that functionallity anymore and it
simplifies the code to exclude it.

Comment 4

[Mats Palmgren (inactive)]

Attachment: Bug 1590376 part 2 - Remove (XUL) nsResizerFrame since it serves no purpose anymore. r=emilio

Depends on D105926

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:mats, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00ed65f43cb2
part 1 - Add a XULResizerElement and move all nsResizerFrame's event handling code there.  r=ntim,smaug
https://hg.mozilla.org/integration/autoland/rev/f137d6e73641
part 2 - Remove (XUL) nsResizerFrame since it serves no purpose anymore.  r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/656906f99173
Add missing include to un-bust non-unified builds.

Comment 8

[Atila Butkovits]

Backed out for causing failures at test_resizer_ctrl_click.xhtml.

Backout link: https://hg.mozilla.org/integration/autoland/rev/27ea3966f4c9ab75a4e755ff4a2f8ee01322a427

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=FXfhBp7qRGS2y1Rfy0oEjg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=15e9b4e9070c569c838f85ca8ceccbf4d52080cc

Failure log: https://treeherder.mozilla.org/logviewer?job_id=380397561&repo=autoland&lineNumber=135942

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fae0dee3f92
part 1 - Add a XULResizerElement and move all nsResizerFrame's event handling code there.  r=ntim,smaug
https://hg.mozilla.org/integration/autoland/rev/b11c52596655
part 2 - Remove (XUL) nsResizerFrame since it serves no purpose anymore.  r=emilio

Comment 10

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/8fae0dee3f92
https://hg.mozilla.org/mozilla-central/rev/b11c52596655