1590421 - Perma browser_ext_browserAction_contextMenu.js when Gecko version increases to 73 on 2019-12-02

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect, P2)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:
Version increase: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=272375502&revision=de9c063a11c4dff69eadce48a38205c01441aa3a&searchStr=browser-chrome

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272375502&repo=try&lineNumber=10356

[task 2019-10-22T12:44:55.154Z] 12:44:55 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js | undefined assertion name -
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - Buffered messages logged at 12:44:55
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - Restore initial state
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - Buffered messages finished
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js | parent must be in snapshot. Has []. - false == true - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertEvents :: line 138
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - Stack trace:
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - resource://testing-common/TelemetryTestUtils.jsm:assertEvents:138
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js:assertTelemetryMatches:64
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js:browseraction_contextmenu_manage_extension:353
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1067
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1102
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:930
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-22T12:44:55.155Z] 12:44:55 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js | Uncaught exception - at resource://testing-common/TelemetryTestUtils.jsm:162 - TypeError: snapshot is undefined
[task 2019-10-22T12:44:55.156Z] 12:44:55 INFO - Stack trace:
[task 2019-10-22T12:44:55.156Z] 12:44:55 INFO - assertEvents@resource://testing-common/TelemetryTestUtils.jsm:162:20
[task 2019-10-22T12:44:55.156Z] 12:44:55 INFO - assertTelemetryMatches@chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js:64:22
[task 2019-10-22T12:44:55.156Z] 12:44:55 INFO - browseraction_contextmenu_manage_extension@chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js:353:25
[task 2019-10-22T12:44:55.156Z] 12:44:55 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1067:34
[task 2019-10-22T12:44:55.156Z] 12:44:55 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1102:11
[task 2019-10-22T12:44:55.156Z] 12:44:55 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:930:14
[task 2019-10-22T12:44:55.156Z] 12:44:55 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:805:67
[task 2019-10-22T12:44:55.156Z] 12:44:55 INFO - Leaving test bound browseraction_contextmenu_manage_extension
[task 2019-10-22T12:44:55.156Z] 12:44:55 INFO - Entering test bound browseraction_contextmenu_remove_extension

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

These test failures from the 73 Beta simulation are triggered by telemetry events currently set to expire on Firefox 73.
I just filed Bug 1590736 to track their renewal and added it as a dependency of this issue.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

This should have been already fixed by Bug 1590736, I didn't close it yet because it should be verified by the next beta simulation.
In the meantime I'm assigning it to myself and setting it as a P2.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in latest version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=f3c841f03c729c5cadc17a5c7b3440557ad1ac8e

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Settings qe-verify- to take this out from the QA queue. The fix has been already verified by a beta simulation as mentioned in comment 4.