1590428 - Enable Picture-in-Picture feature on Windows by default

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

We're doing a slow rollout in 71, which we expect to be at 100% before 72 reaches release. So this bug is about landing the full pref flip in 72 for Windows.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Slight change of plans here. pascalc and astevenson discussed the staged rollout, and have come to the conclusion that the feature is stable enough and has received enough positive reaction to allow us to just enable it by default without the staged rollout.

So in this bug, I'm going to post patches for:

1. mozilla-central, which enabled Picture-in-Picture on Windows by default, out to release
2. mozilla-beta, which enables Picture-in-Picture on Windows by default, out to release

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1590428 - Enable Picture-in-Picture by default on Windows. r?mstriemer

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1590428 - Enable Picture-in-Picture by default on Windows. r?mstriemer

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9104935 [details]
Bug 1590428 - Enable Picture-in-Picture by default on Windows. r?mstriemer

Beta/Release Uplift Approval Request

• User impact if declined: If declined, Picture-in-Picture will not be enabled for late-beta and release users for Firefox 70.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This takes a pref that is configured to be true on EARLY_BETA_OR_EARLIER, and makes it true by default.
• String changes made/needed: None.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1f61df720b5
Enable Picture-in-Picture by default on Windows. r=mstriemer

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d1f61df720b5

Comment 7

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9104935 [details]
Bug 1590428 - Enable Picture-in-Picture by default on Windows. r?mstriemer

Planned uplift, approved for 71 beta 6 thanks.

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/20535ed29ac3

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Release Note Request (optional, but appreciated)
[Why is this notable]:

A new feature has been enabled for Windows users that allows them to pop some video elements out into an always-on-top video player.

[Affects Firefox for Android]:

No.

[Suggested wording]:

Windows users now have the ability to pop out videos on the web into an always-on-top video player using the Picture-in-Picture feature! For most videos, this can be accomplished by hovering the video with the mouse, and clicking on the Picture-in-Picture toggle.

[Links (documentation, blog post, etc)]:

• Originally blogged about here: https://hacks.mozilla.org/2019/07/testing-picture-in-picture-for-videos-in-firefox-69/, but I'm hoping to put another blog post together for the release to describe how it works.
• SUMO article on how to control the feature: https://support.mozilla.org/en-US/kb/turn-picture-picture-mode

Comment 10

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Thanks, I updated the note we had with this wording and linked it to the SUMO article as I think the original blog post was more for a nightly audience.

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1f61df720b5

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Hi dluca,

It looks like attachment 9104935 [details] was improperly applied to beta. If you look at the posted patch:

https://phabricator.services.mozilla.com/D50949

and the commit:

https://hg.mozilla.org/releases/mozilla-beta/rev/20535ed29ac3

There's a pretty clear discrepancy. This means that in the latest beta, PiP has been erroneously disabled.

What process do we need to go through in order to attempt a re-land of attachment 9104935 [details]?

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry for the trouble, https://hg.mozilla.org/releases/mozilla-beta/rev/118b771708e4 drops the #if defined(EARLY_BETA_OR_EARLIER) || defined(MOZ_DEV_EDITION) in the #if defined(XP_WIN).

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Great, thank you!

Comment 15

[Cristian Craciun]

Build ID 20191107101713
User Agent Mozilla/5.0 (Windows NT 10.0; rv:71.0) Gecko/20100101 Firefox/71.0

Verified as fixed on the latest version of Firefox Beta (71.0b8) on Windows 10.

Comment 16

[Cristian Craciun]

Build ID 20191202091209
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Verified as fixed on the latest version of Firefox Nightly (72.0a1) on Windows 10.