1590486 - Account Settings menu item navigates to force_auth

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Edouard Oger [:eoger]]

STR:

Click avatar in FxA toolbar menu, then account settings.

Expected:
FxA settings page opens.

Actual:
FxA force auth page opens.

From mozregression it seems that either bug 1574051 or bug 1574052 was the culprit.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1590486 - ensure FxA web channels can grab the session token. r?eoger

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5503bc49a73
ensure FxA web channels can grab the session token. r=eoger

Comment 5

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&searchStr=xpc&fromchange=c5503bc49a73e9b508b79973c9314269a0f1cc25&tochange=f1b618576af66573bff8d092d37d2189c6619c30&group_state=expanded&selectedJob=272656888

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272656888&repo=autoland&lineNumber=4853

Backout link: https://hg.mozilla.org/integration/autoland/rev/2dee4e611ea910d522d49ffa26fd88c5fbdf1f67

[task 2019-10-23T22:51:15.969Z] 22:51:15 WARNING - TEST-UNEXPECTED-FAIL | services/fxaccounts/tests/xpcshell/test_web_channel.js | xpcshell return code: 0
[task 2019-10-23T22:51:15.969Z] 22:51:15 INFO - TEST-INFO took 1714ms
[task 2019-10-23T22:51:15.969Z] 22:51:15 INFO - >>>>>>>
[task 2019-10-23T22:51:15.969Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.969Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.970Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.970Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.970Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.970Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.970Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.970Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.970Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.970Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.970Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.970Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.971Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2632
[task 2019-10-23T22:51:15.971Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.971Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.971Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-10-23T22:51:15.971Z] 22:51:15 INFO - PID 5373 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 3482: ReferenceError: reference to undefined property "process"
[task 2019-10-23T22:51:15.971Z] 22:51:15 INFO - PID 5373 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 11041: ReferenceError: reference to undefined property "Object"
[task 2019-10-23T22:51:15.972Z] 22:51:15 INFO - PID 5373 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 12088: ReferenceError: reference to undefined property "Buffer"
[task 2019-10-23T22:51:15.972Z] 22:51:15 INFO - PID 5373 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 16620: TypeError: Symbol.toStringTag is read-only
[task 2019-10-23T22:51:15.972Z] 22:51:15 INFO - PID 5373 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 16620: TypeError: Symbol.toStringTag is read-only
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - PID 5373 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 16620: TypeError: Symbol.toStringTag is read-only
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - PID 5373 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 16620: TypeError: Symbol.toStringTag is read-only
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - PID 5373 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 16620: TypeError: Symbol.toStringTag is read-only
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - PID 5373 | JavaScript strict warning: resource://testing-common/sinon-7.2.7.js, line 6247: ReferenceError: reference to undefined property "iso-8859-8-i"
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - running event loop
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - PID 5373 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - PID 5373 | [5373, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/workspace/build/src/dom/media/CubebUtils.cpp, line 381
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "process"" {file: "resource://testing-common/sinon-7.2.7.js" line: 3482}]"
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "Object"" {file: "resource://testing-common/sinon-7.2.7.js" line: 11041}]"
[task 2019-10-23T22:51:15.973Z] 22:51:15 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "Buffer"" {file: "resource://testing-common/sinon-7.2.7.js" line: 12088}]"
[task 2019-10-23T22:51:15.974Z] 22:51:15 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "TypeError: Symbol.toStringTag is read-only" {file: "resource://testing-common/sinon-7.2.7.js" line: 16620}]"
[task 2019-10-23T22:51:15.974Z] 22:51:15 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "TypeError: Symbol.toStringTag is read-only" {file: "resource://testing-common/sinon-7.2.7.js" line: 16620}]"
[task 2019-10-23T22:51:15.974Z] 22:51:15 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "TypeError: Symbol.toStringTag is read-only" {file: "resource://testing-common/sinon-7.2.7.js" line: 16620}]"
[task 2019-10-23T22:51:15.974Z] 22:51:15 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "TypeError: Symbol.toStringTag is read-only" {file: "resource://testing-common/sinon-7.2.7.js" line: 16620}]"
[task 2019-10-23T22:51:15.974Z] 22:51:15 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "TypeError: Symbol.toStringTag is read-only" {file: "resource://testing-common/sinon-7.2.7.js" line: 16620}]"
[task 2019-10-23T22:51:15.974Z] 22:51:15 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "iso-8859-8-i"" {file: "resource://testing-common/sinon-7.2.7.js" line: 6247}]"
[task 2019-10-23T22:51:15.974Z] 22:51:15 INFO - services/fxaccounts/tests/xpcshell/test_web_channel.js | Starting
[task 2019-10-23T22:51:15.974Z] 22:51:15 INFO - (xpcshell/head.js) | test pending (2)
[task 2019-10-23T22:51:15.974Z] 22:51:15 INFO - TEST-PASS | services/fxaccounts/tests/xpcshell/test_web_channel.js |

Comment 6

[Mark Hammond [:markh] [:mhammond]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=090946ff6fe20563d8c232218919a2ff579f4112

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9e0d3054d08
ensure FxA web channels can grab the session token. r=eoger

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b174a43f925
Fix eslint failure. r=eslint-fix

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f9e0d3054d08
https://hg.mozilla.org/mozilla-central/rev/0b174a43f925

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.