1590487 - Unexpected autofilled entries for "place:" and "about:" bookmarked uris

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[infinita740]

Attachment: Annotation 2019-10-22 190841.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

Use firefox to sync to multiple devices.

After some time, multiple "bad" entries got synced between browsers.

Actual results:

No bad suggestions should be created or synced.

Example "bad" entries (suggestions):

• reader/
• place:type=6&sort=14&maxResults=10/

PS: if i connect the same account on a new profile, those suggestions are synced

Expected results:

These "suggestions" should not be created or synced as they are not history or bookmarks.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[infinita740]

I found where the "reader/" suggestion came from and clear steps to reproduce.

Steps:

1. Open an article
2. Toggle Reader mode
3. Bookmark the page
4. Type "read" in url bar

What happens:
"reader/" is suggested and redirect to an error page

What should have happened:
Correct URL in bookmarks should be suggested in step 4
OR
Normal URL should be added to bookmarks in step 3

I could not find where the "place:type=6&sort=14&maxResults=10/" suggestion comes from.

Comment 3

[Marco Bonardo [:mak]]

I don't think this has anything to do with Sync or bad entries, it's more likely a bug in autofill.

"place:type=6&sort=14&maxResults=10" looks like Bug 1503293, they exist, should be filtered out but it doesn't happen.

The "reader/" entry is also related to autofill, we strip the protocol "about" and end up autofilling "reader/", that is wrong.
May be related to the fix in bug 1560676.

Comment 4

[infinita740]

I think you are right.

After some research I found the "place:..." entry in places.sqlite.

After removing them they are no longer suggested.

Should i résolve the bug as duplicata as it seems related to 1503293 & 1560686?

Comment 5

[Marco Bonardo [:mak]]

you shouldn't remover place: entries, and for sure you should never run queries on places.sqlite, whatever is the reason. Those entries are necessary for internal use, they should just not be shown in the urlbar.

We can keep this as a bug tracking the other 2, for now.