1590528 - The DNS suffix is not always computed when Firefox starts up

Status: VERIFIED FIXED

(Core :: Networking, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

It seems CheckAdaptersAddresses isn't always called when Firefox starts up - this means that sometimes we don't have a DNS suffix list, even though we should.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1590528 - Call CheckAdaptersAddresses at startup r=kershaw

The problem is that the suffix is not always computed when Firefox starts up.
This patch adds a pref network.notify.initial_call that controls whether
CheckAdaptersAddresses gets called imediately after.
This call is necessary in order to compute the suffix list, VPN status, etc.

This patch also ensures that OnDnsSuffixListUpdated gets called by
NetlinkService::ComputeDNSSuffixList on Android. This notification is
necessary for the TRRService to pick up the suffix list.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91c517133cc3
Call CheckAdaptersAddresses at startup r=kershaw

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/91c517133cc3

Comment 4

[Julien Cristau [:jcristau]]

Did you want to uplift this?

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 9112588 [details]
Bug 1590528 - Call CheckAdaptersAddresses at startup r=kershaw

Beta/Release Uplift Approval Request

• User impact if declined: Users with TRR enabled will have an unpredictable behaviour when resolving hostnames that are part of the DNS suffix list (or VPN/proxy detection)
  Without this patch the DNS suffix isn't computed when Firefox is first run, so until the first network change event it would use TRR to resolve domains that are part of the local DNS suffix, after that it won't.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Similar to the test plans for bug 1595025 (and dependencies) - be on a network with a DNS suffix, run Firefox, attempt to load a subdomain of that suffix, make sure it doesn't get sent to the TRR server.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): These changes mostly affect windows - it makes sure that CheckAdaptersAddresses also gets called immediately after startup (off main thread) in order to compute the suffix list, VPN/proxy detection, etc.
  The code is controlled by a pref.

The Linux bits of the patch just make sure we call OnDnsSuffixListUpdated after every ComputeDNSSuffixList call (no pref for this bit)

• String changes made/needed:

Comment 6

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 73.0a1 (BuildId:20191212095326) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit. Thanks for fixing this !

Pending a beta uplift.

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9112588 [details]
Bug 1590528 - Call CheckAdaptersAddresses at startup r=kershaw

ok let's get this in 72.0b6

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e126c811e8e3

Comment 9

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

This issue is verified fixed using Firefox 72.0b7 on Windows 10 64bit.