1590550 - Intermittent /css/css-overflow/dynamic-visible-to-clip-001.html | Testing http://web-platform.test:8000/css/css-overflow/dynamic-visible-to-clip-001.html == http://web-platform.test:8000/css/css-overflow/clip-001-ref.html

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: dvarga [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=272460175&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/PJg2NDQoRO68PxHeaejuXQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/PJg2NDQoRO68PxHeaejuXQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2019-10-22T20:44:06.602Z] 20:44:06     INFO - TEST-START | /css/css-overflow/dynamic-visible-to-clip-001.html
[task 2019-10-22T20:44:06.605Z] 20:44:06     INFO - PID 6200 | ++DOMWINDOW == 7 (0x7fd728eb9400) [pid = 6291] [serial = 7] [outer = 0x7fd72a0d02e0]
[task 2019-10-22T20:44:06.606Z] 20:44:06     INFO - PID 6200 | [Child 6291, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-22T20:44:06.607Z] 20:44:06     INFO - PID 6200 | [Child 6291, Main Thread] WARNING: NS_ENSURE_TRUE(frame) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 821
[task 2019-10-22T20:44:06.615Z] 20:44:06     INFO - PID 6200 | ++DOCSHELL 0x7f75dec76800 == 5 [pid = 6200] [id = {d1d45fb4-5097-4afb-9200-b73f54dcc134}]
[task 2019-10-22T20:44:06.615Z] 20:44:06     INFO - PID 6200 | ++DOMWINDOW == 11 (0x7f75e31cf7a0) [pid = 6200] [serial = 11] [outer = (nil)]
[task 2019-10-22T20:44:06.616Z] 20:44:06     INFO - PID 6200 | ++DOMWINDOW == 12 (0x7f75f2b33400) [pid = 6200] [serial = 12] [outer = 0x7f75e31cf7a0]
[task 2019-10-22T20:44:06.636Z] 20:44:06     INFO - PID 6200 | [Parent 6200, Main Thread] WARNING: Attempting to get a displayport from a content with no primary frame!: file /builds/worker/workspace/build/src/layout/base/nsLayoutUtils.cpp, line 767
[task 2019-10-22T20:44:06.705Z] 20:44:06     INFO - PID 6200 | ++DOCSHELL 0x7f863cfc3000 == 1 [pid = 6344] [id = {a4c38a49-36a1-49d6-81ff-0faed4b8655e}]
[task 2019-10-22T20:44:06.806Z] 20:44:06     INFO - PID 6200 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpMIaRM0.mozrunner/runtests_leaks_3893_tab_pid6379.log
[task 2019-10-22T20:44:06.826Z] 20:44:06     INFO - PID 6200 | ++DOMWINDOW == 1 (0x7f863ce02f20) [pid = 6344] [serial = 1] [outer = (nil)]
[task 2019-10-22T20:44:06.842Z] 20:44:06     INFO - PID 6200 | [Child 6379, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 732
[task 2019-10-22T20:44:06.842Z] 20:44:06     INFO - PID 6200 | ++DOMWINDOW == 2 (0x7f863d9a4000) [pid = 6344] [serial = 2] [outer = 0x7f863ce02f20]
[task 2019-10-22T20:44:06.898Z] 20:44:06     INFO - PID 6200 | [Child 6344, Main Thread] WARNING: NS_ENSURE_TRUE(frame) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 821
[task 2019-10-22T20:44:07.135Z] 20:44:07     INFO - PID 6200 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-10-22T20:44:07.453Z] 20:44:07     INFO - PID 6200 | [Child 6379, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/workspace/build/src/dom/ipc/ContentChild.cpp, line 1786
[task 2019-10-22T20:44:07.489Z] 20:44:07     INFO - PID 6200 | 1571777047481	Marionette	INFO	Testing http://web-platform.test:8000/css/css-overflow/dynamic-visible-to-clip-001.html == http://web-platform.test:8000/css/css-overflow/clip-001-ref.html
[task 2019-10-22T20:44:07.497Z] 20:44:07     INFO - PID 6200 | ++DOMWINDOW == 3 (0x7f863d9aac00) [pid = 6344] [serial = 3] [outer = 0x7f863ce02f20]
[task 2019-10-22T20:44:07.512Z] 20:44:07     INFO - PID 6200 | [Child 6344, Main Thread] WARNING: NS_ENSURE_TRUE(frame) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 821
[task 2019-10-22T20:44:07.617Z] 20:44:07     INFO - PID 6200 | ++DOMWINDOW == 4 (0x7f863ece3000) [pid = 6344] [serial = 4] [outer = 0x7f863ce02f20]
[task 2019-10-22T20:44:07.637Z] 20:44:07     INFO - PID 6200 | [Child 6344, Main Thread] WARNING: NS_ENSURE_TRUE(frame) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 821
[task 2019-10-22T20:44:07.758Z] 20:44:07     INFO - PID 6200 | ++DOMWINDOW == 5 (0x7f863ec6dc00) [pid = 6344] [serial = 5] [outer = 0x7f863ce02f20]
[task 2019-10-22T20:44:07.774Z] 20:44:07     INFO - PID 6200 | [Child 6344, Main Thread] WARNING: NS_ENSURE_TRUE(frame) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 821
[task 2019-10-22T20:44:07.937Z] 20:44:07     INFO - PID 6200 | 1571777047935	Marionette	INFO	No differences allowed
[task 2019-10-22T20:44:07.998Z] 20:44:07     INFO - PID 6200 | [Child 6291, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-22T20:44:07.999Z] 20:44:07     INFO - PID 6200 | [Child 6291, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-22T20:44:08.027Z] 20:44:08     INFO - TEST-UNEXPECTED-FAIL | /css/css-overflow/dynamic-visible-to-clip-001.html | Testing http://web-platform.test:8000/css/css-overflow/dynamic-visible-to-clip-001.html == http://web-platform.test:8000/css/css-overflow/clip-001-ref.html
[task 2019-10-22T20:44:08.028Z] 20:44:08     INFO - Found 20000 pixels different, maximum difference per channel 255

Comment 1

[Emilio Cobos Álvarez (:emilio)]

So this is doing a dynamic change in an onload event handler, and expect it to be painted. I have a pernosco trace of this...

I think this is some sort of RDL bug or such. This is the point in time where we invalidate the frame's layout + paint.

Then we do layout, and reflow in such a way that scrollbars in the container end up disappearing (indeed that's the purpose of the test). We get a bunch of other repaint requests for scrollbars and such, and eventually we paint, but it seems that the element is not correctly clipped...

Matt, do you have any idea of where this may be going wrong?

Comment 2

[Intermittent Failures Robot]

16 failures in 786 pushes (0.02 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 8
• mozilla-central: 6
• mozilla-inbound: 2

Platform breakdown:

• windows10-64-qr: 4
• macosx1014-64-shippable: 1
• linux64: 6
• linux64-qr: 2
• linux64-ccov: 1
• windows10-64-ccov: 1
• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1590550&startday=2019-10-24&endday=2019-10-24&tree=all

Comment 3

[Intermittent Failures Robot]

59 failures in 4182 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #22 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 32
• mozilla-central: 19
• mozilla-inbound: 2
• try: 6

Platform breakdown:

• linux64: 26
• linux64-qr: 9
• macosx1014-64: 4
• linux64-ccov: 5
• windows10-64-qr: 9
• macosx1014-64-shippable: 2
• windows10-64-ccov: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1590550&startday=2019-10-21&endday=2019-10-27&tree=all

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I think we reproduced this: https://pernos.co/debug/RNSUMtw8HbJ6WxOTS5-tMQ/index.html

It's from a try push but it doesn't look like the failure is related to the push at all.

Comment 5

[Intermittent Failures Robot]

18 failures in 865 pushes (0.021 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 15
• try: 1
• mozilla-central: 2

Platform breakdown:

• linux64: 9
• windows10-64-qr: 2
• linux64-qr: 5
• macosx1014-64-shippable: 1
• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1590550&startday=2019-10-29&endday=2019-10-29&tree=all

Comment 6

[Intermittent Failures Robot]

15 failures in 814 pushes (0.018 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 8
• try: 3
• mozilla-central: 4

Platform breakdown:

• macosx1014-64: 4
• linux64: 5
• linux64-qr: 1
• linux64-ccov: 1
• android-em-7-0-x86_64: 1
• windows10-64-qr: 2
• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1590550&startday=2019-10-30&endday=2019-10-30&tree=all

Comment 7

[Andreea Pavel [:apavel]]

Hi Emilio, by the looks of it, this will soon reach the disable recommended queue, are there any updates here?

Comment 8

[Intermittent Failures Robot]

82 failures in 4314 pushes (0.019 failures/push) were associated with this bug in the last 7 days.

This is the #13 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 47
• mozilla-central: 23
• try: 12

Platform breakdown:

• linux64: 37
• linux64-qr: 15
• macosx1014-64: 8
• windows10-64-qr: 7
• macosx1014-64-shippable: 1
• windows10-64-ccov: 6
• linux64-ccov: 6
• android-em-7-0-x86_64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1590550&startday=2019-10-28&endday=2019-11-03&tree=all

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Waiting on Matt, but I'll try to dig a bit more now.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

So I think I found the issue... Also why is this bug in the Web Painting component?

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1590550 - Don't do the "simple display list" optimization when we have overflow clips. r=miko,mattwoodrow

The previous code tried to do it, but it did it wrongly, as the overflow clip
comes from the parent, not the child.

Thus when we change a style that influences it, we weren't invalidating the
SIMPLE_DISPLAY_LIST bit, and such.

Make the reftest that caught this fail more reliable.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e75d9dbb4853
Don't do the "simple display list" optimization when we have overflow clips. r=mattwoodrow

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20076 for changes under testing/web-platform/tests

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 15

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on contain-paint-clip-001.html

backout: https://hg.mozilla.org/integration/autoland/rev/c85ae1289d33e348bdda56d6ae3f61a987f784d7

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-macosx1014-64%2Fdebug-web-platform-tests-reftests-e10s-6%2Cw%28wr6%29&revision=e75d9dbb4853462d60ad18a589b67e379725c41f&selectedJob=274476554

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274476554&repo=autoland&lineNumber=68854

Comment 16

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1590550 - Don't apply contain: paint inappropriately.

This fixes css/css-contain/contain-paint-{002,012,024}.html when not using the
fast path (i.e., with the following patch).

Also invert the check in IsStackingContext as IsFrameOfType is a virtual method,
and IsContain* is just a bitflag.

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1590550 - Don't do the "simple display list" optimization when we have overflow clips.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2248bd863a26
Don't apply contain: paint inappropriately. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/6400ccbce0a2
Don't do the "simple display list" optimization when we have overflow clips. r=mattwoodrow

Comment 20

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 21

[Narcis Beleuzu [:NarcisB]]

Backed out for wr failures on contain-paint-025.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/83a1f4dbc511ced02891088a68d74c96a0dd98b6
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274751019&repo=autoland&lineNumber=40397

Comment 22

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 23

[Intermittent Failures Robot]

18 failures in 1017 pushes (0.018 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• mozilla-central: 8
• autoland: 9
• try: 1

Platform breakdown:

• linux64: 4
• windows10-64-ccov: 3
• linux64-qr: 8
• linux64-ccov: 2
• windows10-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1590550&startday=2019-11-05&endday=2019-11-05&tree=all

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc1b0170ef11
Don't apply contain: paint inappropriately. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/b4ef304c1c6b
Don't do the "simple display list" optimization when we have overflow clips. r=mattwoodrow

Comment 25

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 26

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/bc1b0170ef11
https://hg.mozilla.org/mozilla-central/rev/b4ef304c1c6b

Comment 27

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 28

[Intermittent Failures Robot]

37 failures in 4850 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• mozilla-central: 14
• try: 3
• autoland: 20

Platform breakdown:

• linux64-qr: 12
• windows10-64-qr: 3
• linux64: 11
• macosx1014-64: 3
• android-em-7-0-x86_64: 1
• windows10-64-ccov: 4
• linux64-ccov: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1590550&startday=2019-11-04&endday=2019-11-10&tree=all