Closed Bug 1590620 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19841 - Refactor MediaQueryList tests

Categories

(Core :: DOM: CSS Object Model, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(2 files)

Sync web-platform-tests PR 19841 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19841
Details from upstream follow.

Alexey Shvayka <shvaikalesh@gmail.com> wrote:

Refactor MediaQueryList tests

Fixes #19688 via bdbff2f.

PR 19841 applied with additional changes from upstream: 74286c98a9f403921e3d90af5b8693b437733ff8
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 9 tests and 62 subtests

Firefox

OK : 4
PASS : 26

Chrome

OK : 3
PASS : 24
TIMEOUT: 2
NOTRUN : 1

Safari

OK : 4
PASS : 19
FAIL : 7

Existing tests that now have a worse result

/css/cssom-view/matchMedia.xht
MediaQueryList.addListener is a Function: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.matches exists: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.matches for "(width: 200px)": Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.matches for "(max-height: 50px)": Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
window.matchMedia is a Function: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.media for "all": Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.addListener exists: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.matches for "(min-aspect-ratio: 1/1)": Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.media is readonly: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.removeListener exists: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.matches for "not all": Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.matches for "(min-width: 150px)": Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.removeListener is a Function: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.media syntax error: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: FAIL->MISSING
MediaQueryList.matches for "all": Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.matches for "(max-width: 199px), all and (min-width: 200px)": Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
MediaQueryList.media exists: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
window.matchMedia("all"): Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: FAIL->MISSING
MediaQueryList.matches is readonly: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

/css/cssom-view/MediaQueryListEvent.html
MediaQueryListEvent::media is read-only IDL attribute: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: FAIL->MISSING
extends Event: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: FAIL->MISSING
MediaQueryListEvent::matches is read-only IDL attribute: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: FAIL->MISSING
type argument is required: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: FAIL->MISSING

/css/cssom-view/matchMediaAddListener.html: Firefox: OK->MISSING, Chrome: OK->MISSING, Safari: OK->MISSING

/css/cssom-view/MediaQueryList-001.html: Firefox: OK->MISSING, Chrome: OK->MISSING, Safari: OK->MISSING
matchMedia: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

/css/cssom-view/MediaQueryList-with-empty-string.html: Firefox: OK->MISSING, Chrome: OK->MISSING, Safari: OK->MISSING
cssom-view - MediaQueryList with empty string: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

/css/cssom-view/matchMediaAddListener-handleEvent.html: Firefox: OK->MISSING, Chrome: OK->MISSING, Safari: OK->MISSING
throws if handleEvent is falsy and not callable: Firefox: PASS->MISSING, Chrome: FAIL->MISSING, Safari: FAIL->MISSING
looks up handleEvent method on every event dispatch: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: FAIL->MISSING
calls handleEvent method of event listener: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: FAIL->MISSING
rethrows errors when getting handleEvent: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: FAIL->MISSING
doesn't look up handleEvent method on callable event listeners: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
throws if handleEvent is thruthy and not callable: Firefox: PASS->MISSING, Chrome: FAIL->MISSING, Safari: FAIL->MISSING

Automatic update from web-platform-tests
Refactor MediaQueryList tests

Fixes #19688 via bdbff2f. Fixes #14429.
Follow-up of #18390.
Related: #18389.

  • Add "width" and "height" paramters to createIFrame harness
  • Reflow <iframe> document in createIFrame
  • Introduce higher-level createMQL harness
  • Make triggerMQLEvent work with MediaQueryList
  • Use createMQL in "handleEvent" tests
  • Use promise_rejects_* and EventWatcher in "handleEvent" tests
  • Split "matchMedia.xht" and use new harness
  • Merge in "matchMediaAddListener.html" and use new harness
  • Rename "handleEvent" test
  • Merge in empty string test
  • Merge in "(min-width: 1px)" test
  • Add "use strict" directive
  • Remove bogus test
  • Remove extra MediaQueryList IDL tests
  • Remove extra MediaQueryListEvent IDL tests
    --

wpt-commits: 93d54359245275eac0045011572cfb87c65b8009
wpt-pr: 19841

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1edba25d9cb1
[wpt PR 19841] - Refactor MediaQueryList tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e3527f492a98
[wpt PR 19841] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: