Closed Bug 1590637 Opened 4 months ago Closed 4 months ago

Some addressbooks not available on first startup

Categories

(MailNews Core :: Address Book, defect)

defect
Not set

Tracking

(thunderbird71 fixed, thunderbird72 fixed)

RESOLVED FIXED
Thunderbird 72.0
Tracking Status
thunderbird71 --- fixed
thunderbird72 --- fixed

People

(Reporter: wsmwk, Assigned: darktrojan)

References

Details

(Keywords: regression)

Attachments

(2 files)

On my first use of 71.0b1, only my first and last addressbooks (alphabetically, of ~12) had contacts listed. All the mork ABs were .bak files, and sqlite files of those addressbooks showed as 32k IIRC. I didn't see population of ABs improve during the 10-15 minutes I had the instance running.

On second startup all addressbooks were populated.

Keywords: regression
Flags: needinfo?(geoff)

I didn't say it earlier - we clearly cannot ship this in beta. I haven't tested update more than once and I didn't keep error console, so ATM sorry I don't have more details.

only my first and last addressbooks

might have been the second last (it was late)

Anyone tested after migration with an ldap book configured? (mine isn't working and I think it should be - but perhaps it was previously broken)

OK, Wayne convinced me to migrate my production profile with 25 ABs, 4 of which LDAP. Those LDAP ones are just 0 byte MAB files which don't seem to get migrated.

The other 21 ABs were migrated, I have 21 BAKs, but only 19 SQLite files, history.mab.bak has no equivalent, neither does listexpansion.mab.bak.

So it's all semi good, however, I also got this error. So something was still locked from the conversion.

I've just seen that message for the first time too. That's not good.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)

I guess I saw it before, see bug 1581765 comment #7. But back then I didn't take a screenshot and I couldn't remember whether the message was for a MAB or SQLite file :-(

Was abook-13 an empty address book?

Flags: needinfo?(jorgk)

Scratch that, what I thought I'd figured out doesn't make sense.

Flags: needinfo?(jorgk)

Almost empty, I made it for a test, I'll send it to you.

I repeated the test, number 13 was locked again. I'll send you the entire profile.

Try as I might to avoid waking up the beast address book manager, but something unknown is still causing it to stir.

"Never mind," I say, "I'll just reload it and everything will be fine."

Yeah, right. Nothing is that easy. Somebody previous traveller in these parts used do_GetService where they should've used do_CreateInstance and reloading the address book just brings back the previous state.

I need a holiday.

Attachment #9103829 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9103829 [details] [diff] [review]
1590637-addrbook-reload-1.diff

Yes, that works better with my zoo of address books. Test passes, too :-)
Attachment #9103829 - Flags: review+
Attachment #9103829 - Flags: approval-comm-beta+
Comment on attachment 9103829 [details] [diff] [review]
1590637-addrbook-reload-1.diff

Review of attachment 9103829 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9103829 - Flags: review?(mkmelin+mozilla) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d4dc1d4176db
Reload address book after migration. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0
You need to log in before you can comment on or make changes to this bug.