1590641 - Improve the byteSize-of-string.js test

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

Noticed while updating it for bug 1330776:

• It claims external strings can't be created in the shell, but we have newExternalString now. We would also need to implement the externalStringSizeofCallback - a bit annoying because it means NewExternalString has to move from TestingFunctions.cpp to shell/js.cpp Or maybe better: the sizeOf function could be grouped with the finalization callback in a static struct so we can have multiple external-size-of implementations.
• The use of "extensible strings" is wrong, this string for example isn't extensible, it's just a plain JSLinearString.

Comment 1

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #0)

• The use of "extensible strings" is wrong, this string for example isn't extensible, it's just a plain JSLinearString.

Oh never mind this, I think I was misreading the test.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1590641 - Test external string sizes in byteSize-of-string.js. r?jwalden!

Bug 1590776 fixed memory reporting for external strings allocated by the
newExternalString testing function so we can now add some tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26eaf3f0479b
Test external string sizes in byteSize-of-string.js. r=jwalden

Comment 4

[Andrei Ciure[:aciure]]

Backed out changeset 26eaf3f0479b (bug 1590641) for causing Spidermonkey bustages

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=26eaf3f0479b535b44156377ab328c79b48237ac

backout: https://hg.mozilla.org/integration/autoland/rev/7a5e795ba3582f2712ce859a409e994063c1e429

Comment 5

[Jan de Mooij [:jandem]]

Fun, on Windows the smallest malloc bucket size is 8 bytes (on 32-bit) and 16 bytes (on 64-bit) instead of 4 and 8 bytes on other platforms...

https://searchfox.org/mozilla-central/rev/74cc0f4dce444fe0757e2a6b8307d19e4d0e0212/memory/build/mozjemalloc.cpp#384-385

Comment 6

[Jim Blandy :jimb]

Thanks, Jan!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21014b340630
Test external string sizes in byteSize-of-string.js. r=jwalden

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/21014b340630