Improve the byteSize-of-string.js test
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
Noticed while updating it for bug 1330776:
- It claims external strings can't be created in the shell, but we have newExternalString now. We would also need to implement the
externalStringSizeofCallback- a bit annoying because it means NewExternalString has to move from TestingFunctions.cpp to shell/js.cpp Or maybe better: the sizeOf function could be grouped with the finalization callback in a static struct so we can have multiple external-size-of implementations. - The use of "extensible strings" is wrong, this string for example isn't extensible, it's just a plain JSLinearString.
|
Assignee | |
Comment 1•5 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #0)
- The use of "extensible strings" is wrong, this string for example isn't extensible, it's just a plain JSLinearString.
Oh never mind this, I think I was misreading the test.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
Bug 1590776 fixed memory reporting for external strings allocated by the
newExternalString testing function so we can now add some tests.
|
|
Assignee | |
Updated•5 years ago
|
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26eaf3f0479b Test external string sizes in byteSize-of-string.js. r=jwalden
|
||
Comment 4•5 years ago
|
||
Backed out changeset 26eaf3f0479b (bug 1590641) for causing Spidermonkey bustages
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=26eaf3f0479b535b44156377ab328c79b48237ac
backout: https://hg.mozilla.org/integration/autoland/rev/7a5e795ba3582f2712ce859a409e994063c1e429
|
|
Assignee | |
Comment 5•5 years ago
|
||
Fun, on Windows the smallest malloc bucket size is 8 bytes (on 32-bit) and 16 bytes (on 64-bit) instead of 4 and 8 bytes on other platforms...
|
||
Comment 6•5 years ago
|
||
Thanks, Jan!
|
|
Assignee | |
Updated•5 years ago
|
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21014b340630 Test external string sizes in byteSize-of-string.js. r=jwalden
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Description
•