1590673 - Crash in [@ mozilla::net::nsHttpChannel::ComputeCrossOriginOpenerPolicyMismatch]

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Frederik Braun [:freddy]]

This bug is for crash report bp-e1814a96-709d-446f-be00-4a8ad0191023.

Top 10 frames of crashing thread:

0 libxul.so mozilla::net::nsHttpChannel::ComputeCrossOriginOpenerPolicyMismatch netwerk/protocol/http/nsHttpChannel.cpp:7400
1 libxul.so mozilla::net::nsHttpChannel::OnStartRequest netwerk/protocol/http/nsHttpChannel.cpp:7738
2 libxul.so nsInputStreamPump::OnStateStart netwerk/base/nsInputStreamPump.cpp:487
3 libxul.so nsInputStreamPump::OnInputStreamReady netwerk/base/nsInputStreamPump.cpp:396
4 libxul.so nsInputStreamReadyEvent::Run xpcom/io/nsStreamUtils.cpp:91
5 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225
6 libxul.so <name omitted> xpcom/threads/nsThreadUtils.cpp:486
7 libxul.so mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:88
8 libxul.so MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290
9 libxul.so nsBaseAppShell::Run widget/nsBaseAppShell.cpp:137

Comment 1

[Frederik Braun [:freddy]]

I have reproducible steps to repeat with the latest Nightly build:

1. Open a New Tab
2. Go to https://resume.github.io/
3. Refresh (hitting CTRL+R)
4. Crash reporter opens

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1590673 - Avoid assertion when assigning Maybe<Policy> r=JuniorHsu

Maybe<T>::emplace has a MOZ_DIAGNOSTIC_ASSERT that the value is not already assigned.
When revalidating, the method ends up being called twice - so we must instead assign to Some(T) to avoid the assertion, since that is the correct way to do this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2041efeb9ee
Avoid assertion when assigning Maybe<Policy> r=JuniorHsu

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d2041efeb9ee

Comment 5

[Ciprian Georgiu, Desktop QA]

I've tried to reproduce this issue with the provided steps from comment 1. Unfortunately, Firefox doesn't crash on Ubuntu 18.04 x64 when refreshing the page on an affected Nightly build (2019-10-23).

Hi, Frederik! Could you please help verifying this bug on FIrefox 72.0.2, since you were able to reproduce the crash?

Comment 6

[Frederik Braun [:freddy]]

I can verify it's fixed.

Comment 7

[Ciprian Georgiu, Desktop QA]

Thanks! Marking this as verified fixed per the above comment.