Closed
Bug 1590776
Opened 5 years ago
Closed 5 years ago
Store the external-string-sizeOf callback with the finalize callback instead of per-runtime
Categories
(Core :: JavaScript Engine, task, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
This will make it possible to implement this callback easily for the NewExternalString testing function (which we want for bug 1590641) without having to move this testing function to shell/js.cpp
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•5 years ago
|
||
This renames the JSStringFinalizer struct to JSExternalStringCallbacks,
makes it a virtual class, and adds a size-of callback to it (to replace
the per-runtime callback).
This will make it possible to implement this callback easily for the
NewExternalString testing function (which we want for bug 1590641)
without having to move this testing function to shell/js.cpp
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/681462911841 Store the external-string-sizeOf callback with the finalize callback instead of per-runtime. r=jwalden,bzbarsky
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•