Unify link coloring code in history implementations.
Categories
(Core :: General, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(16 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
We have a lot of duplicated code in places' history and GeckoView's history. It is a pain to change.
Most of the code I'm interested in should be unified.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
In preparation to unify the link coloring code with GeckoViewHistory, which
uses these hashtables for the equivalent of mObservers, it'd be good if we'd be
using the same.
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
In preparation for moving all the link coloring code.
Assignee | ||
Comment 6•5 years ago
|
||
GetHistoryService should work everywhere.
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
Interestingly the android implementation had a potentially serious bug (was
missing a script blocker).
Assignee | ||
Comment 9•5 years ago
|
||
Assignee | ||
Comment 10•5 years ago
|
||
Assignee | ||
Comment 11•5 years ago
|
||
Now without a duplicate version on another file :)
Assignee | ||
Comment 12•5 years ago
|
||
Depends on D50266
Assignee | ||
Comment 13•5 years ago
|
||
GeckoView does this link clearing stuff (which is somewhat dubious), but always
used to return NS_OK.
The error handling case in Link.cpp was pretty broken anyway (it'd leave the
link marked as registered), so make that infallible, given we fatally assert in
the non-android case.
NotifyVisited is also infallible so make that infallible too.
There's no need to use NS_IMETHOD gunk when not using scriptable XPCOM, and
these functions are not called from script, so make them regular pure-virtual
functions.
Depends on D50478.
Assignee | ||
Comment 14•5 years ago
|
||
Otherwise a page which appends links with different hrefs fast enough could
never see the visited state updated, for example.
Depends on D50480
Assignee | ||
Comment 15•5 years ago
|
||
And make the assertions consistent with places.
Assignee | ||
Comment 16•5 years ago
|
||
This was copied verbatim from places, but the only thing the code can do is
schedule runnables, which outlive the function, so there's no script that can
run.
Depends on D50502.
Comment 17•5 years ago
|
||
Comment 18•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ae141ea79cb8
https://hg.mozilla.org/mozilla-central/rev/6cab6abf119e
https://hg.mozilla.org/mozilla-central/rev/c0ca50bb81ce
https://hg.mozilla.org/mozilla-central/rev/c0b1c51a4ef3
https://hg.mozilla.org/mozilla-central/rev/c340ffe9aa3b
https://hg.mozilla.org/mozilla-central/rev/60601417a731
https://hg.mozilla.org/mozilla-central/rev/d5c1df050f9f
https://hg.mozilla.org/mozilla-central/rev/f18c7c05ffd0
https://hg.mozilla.org/mozilla-central/rev/f9c5be57dacb
https://hg.mozilla.org/mozilla-central/rev/b93b7fb6f7f7
https://hg.mozilla.org/mozilla-central/rev/ceeff631a71b
https://hg.mozilla.org/mozilla-central/rev/10c5d5a32f62
https://hg.mozilla.org/mozilla-central/rev/bdbaba80d7a0
https://hg.mozilla.org/mozilla-central/rev/a4947b14d81f
https://hg.mozilla.org/mozilla-central/rev/2279b41eef85
https://hg.mozilla.org/mozilla-central/rev/f915da42169e
Description
•