1590851 - Customizing menu toolbar - buttons can get lost behind Min/MaxClose buttons

Status: VERIFIED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Charles]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Installed the new 68.2 x64, looking forward to starting afresh.

Renamed old profile (both Roaming and Local), and let TB create a fresh new profile.

Started customizing the toolbars

Actual results:

I removed the WhiteSpace from the Menu Toolbar, then added the Hamburger menu top it on the right side.

The button got 'lost' (I could still barely see it), but I couldn't get to it.

Had to 'Restore Default Set' to recover

Expected results:

Either the Min/Max/Close buttons should be considered unusable space, or they should be considered actual buttons that take up space on the toolbar, so no other button can get lost behind them.

Comment 1

[Jorg K (CEST = GMT+2)]

Please attach a (small) screenshot.

Comment 2

[Richard Marti (:Paenglab)]

No screenshot needed. I know whats the problem.

Comment 3

[Charles]

Thanks Richard., was just getting ready to create a new profile really quick to provide the screenshot...

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1590851-hide-titlebar-placeholder.patch

The titlebar-placeholder was hidden on too many OS versions. It should only hide on Windows 7 Aero where the menu bar is placed below the tabs.

Comment 5

[Jorg K (CEST = GMT+2)]

No screenshot needed. I know what's the problem.

Great ;-) - I don't so what am I reviewing here?

Comment 6

[Jorg K (CEST = GMT+2)]

OK, looks like when you draw the tabs into the titlebar and then customise the menu, the area covers the maximise/mimimise buttons.

Comment 7

[Richard Marti (:Paenglab)]

Correct. It's already visible that the white rectangle (the flex spacer) goes behind the caption buttons. With patch no more.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9104411 [details] [diff] [review]
1590851-hide-titlebar-placeholder.patch

WFM on Windows 10. Thanks.

Comment 9

[Charles]

Wow... that was fast guys...

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0a31f27b32e
Hide the titlebar-placeholder in the menu bar only under Windows 7 Aero. r=jorgk DONTBUILD

Comment 11

[Jorg K (CEST = GMT+2)]

TB 71 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/90cdbc6fa6e2ee7363be9b23d6c2e5010958fe1e

Comment 12

[Jorg K (CEST = GMT+2)]

TB 68.2.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/d8616af75883929f098c93ef03ac15aa4a99812d

Comment 13

[Jorg K (CEST = GMT+2)]

Working in my TB 68.2.1 build.