1590854 - Non-overlay scrollbars are light under dark mode

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement, P2)

Description

[Kirill Grouchnikov]

Attachment: scrollbar.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Open a site that supports the recently added dark mode and observe the vertical scroll bar. Try https://512pixels.net/ or https://sixcolors.com/

Actual results:

The vertical scroll bar is light

Expected results:

The vertical scroll bar should be dark (as in Safari)

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Attachment: poc patch

This is a PoC patch which tries to use overlay scrollbar for scrollbar on dark background. This looks better than current, but still less than ideal. Maybe need some investigation into how Safari renders the dark version of scrollbar.

Also, I suspect this would need to be guarded behind widget.disable-dark-scrollbar pref added in bug 1578377, otherwise we may have problems on reftests as well.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

(I may not have time recently to investigate further.)

Comment 3

[Stephen A Pohl [:spohl]]

Attachment: Bug 1590854: Add support for dark non-overlay scrollbars to macOS. r=#mac-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4a9a44a5e96
Add support for dark non-overlay scrollbars to macOS. r=mac-reviewers,bradwerth

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b4a9a44a5e96