Open Bug 1590855 Opened 5 years ago Updated 2 years ago

Finish converting worker script loader (dom/workers/ScriptLoader.cpp's ScriptLoaderRunnable, ScriptResponseHeaderProcessor) to WorkerRef and ThreadsafeWorkerRef

Categories

(Core :: DOM: Workers, enhancement, P3)

Product:
Core
Component:
DOM: Workers
Type:
enhancement

Tracking

()

People

(Reporter: asuth, Unassigned)

References

Details

Bug 1469579 converted ScriptLoader from a WorkerHolder (ScriptLoaderHolder) to a WorkerHolder, but the ScriptLoaderRunnable instances (and once bug 1575090 lands, ScriptResponseHeaderProcessor) hold raw WorkerPrivate* pointers guaranteed by a StrongWorkerRef. However, they should be holding RefPtr<ThreadSafeWorkerRef> instances instead.

Note that this is a lesser problem. All the uses happen on the main thread and worker script loading uses sync loops, so it's unlikely this is the source of bugs, it's more a hygiene problem.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.