Open Bug 1590856 Opened 2 years ago Updated 2 years ago

Investigate making <checkbox> and <radio> HTML custom elements

Categories

(Toolkit :: XUL Widgets, task)

task
Not set
normal

Tracking

()

People

(Reporter: ntim, Unassigned)

References

(Blocks 2 open bugs)

Details

Probably the annoying bit here is the XUL flex/pack/etc. attributes, but the markup seems trivial to convert.

For the flex/pack/etc attributes I have an idea at https://bugzilla.mozilla.org/show_bug.cgi?id=1590576#c2 that might help.

See Also: → 1590576

(In reply to Brian Grinstead [:bgrins] from comment #1)

For the flex/pack/etc attributes I have an idea at https://bugzilla.mozilla.org/show_bug.cgi?id=1590576#c2 that might help.

I put up a quick demo at https://phabricator.services.mozilla.com/D50301.

It seems like that both radio and checkbox currently support accesskeys, that then inherits onto the child <label> which makes this slightly more tricky... <label>text</label> triggers a nsXULLabelFrame which I believe is used to register the accesskey.

Regarding the accesskey, it might not be that tricky after all since HTML supports the accesskey attribute on HTML elements.

However, one strange thing is that checkboxes/radios create a ButtonBoxFrame: https://searchfox.org/mozilla-central/rev/088e2cf29c59d733d57af43903eb0267dbf72e2a/layout/base/nsCSSFrameConstructor.cpp#4135-4136

You need to log in before you can comment on or make changes to this bug.