1590856 - Investigate making <checkbox> and <radio> HTML custom elements

Status: NEW

(Toolkit :: UI Widgets, task)

Description

[Tim Nguyen :ntim]

Probably the annoying bit here is the XUL flex/pack/etc. attributes, but the markup seems trivial to convert.

Comment 1

[Brian Grinstead [:bgrins]]

For the flex/pack/etc attributes I have an idea at https://bugzilla.mozilla.org/show_bug.cgi?id=1590576#c2 that might help.

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #1)

For the flex/pack/etc attributes I have an idea at https://bugzilla.mozilla.org/show_bug.cgi?id=1590576#c2 that might help.

I put up a quick demo at https://phabricator.services.mozilla.com/D50301.

Comment 3

[Tim Nguyen :ntim]

It seems like that both radio and checkbox currently support accesskeys, that then inherits onto the child <label> which makes this slightly more tricky... <label>text</label> triggers a nsXULLabelFrame which I believe is used to register the accesskey.

Comment 4

[Tim Nguyen :ntim]

Regarding the accesskey, it might not be that tricky after all since HTML supports the accesskey attribute on HTML elements.

However, one strange thing is that checkboxes/radios create a ButtonBoxFrame: https://searchfox.org/mozilla-central/rev/088e2cf29c59d733d57af43903eb0267dbf72e2a/layout/base/nsCSSFrameConstructor.cpp#4135-4136