Closed Bug 1590871 Opened 5 years ago Closed 4 years ago

Please add revert function to sync. Data lost after failure!

Categories

(Firefox :: Sync, enhancement)

72 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED INACTIVE

People

(Reporter: kullai.mate, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Firefox started up after boot when the profile data was only partially available as it was being uncompressed. It started with no extensions, some backup of tabs I used previously and in an overall broken state.
No problem, I'm getting used to this. Tried to set up a partially saved profile with a ram disk. (but I give up now as I'm having problems with Firefox as a whole for days)
I killed Firefox so it doesn't save anything, then detached the ram disk so no backup was made.

Actual results:

After a Windows reboot I load up Firefox and everything works ok. I was reading around about things when the whole browser resets itself to some factory-like state.
I was thinking the extension host crashed or something like this.
But it turns out the broken state got synced to my account and it detected that my profile was older than to online data.

Expected results:

I was searching around around how to roll it back, but found no way yet. Repeated reloads from backed up profiles end up the same. As I see it works as intended.
I disabled Sync and never want to enable it again. It was mostly useless, but until now it didn't do harm.

Component: Untriaged → Sync

I'm sorry you had this problem. It's difficult to know what you mean by the broken state being synced to your account, but it would not have, for example, deleted bookmarks or history. Can you please explain what you mean by this, and could you please visit about:sync-log and upload any sync logs you find there - that should tell us what sync did.

Flags: needinfo?(kullai.mate)

By broken state I mean that it was captured while only some part of the profile was present and it was being loaded while Firefox was accessing it.
I don't really know the inner structure of the profile or the loading mechanism. But for me it seamed like some parts of my configuration was loaded but many was reset to the default. And when I reset everything and it gets synced, only some part of my tabs and history is present (but the history may be related to the backup being out of date at the time of boot). Even the Welcome screen showed up.
While I was looking around to find out what happened I started getting notifications about my extensions being installed. It asked me for permissions for them to install. Then loaded them all as disabled and with default configuration.
This was the time I gave up as I don't think it's worth to try to save that build. It was quite unstable and it was many times consuming more than 30 GB RAM with around 200 tabs open (+ around 600 zombies) and lagged like hell. I actually uninstalled the Dev version since.

All in all I think it worked as per design for how it should be with a new configuration. Actually I was quite impressed with how it disabled 30-40 extensions in a second and kept running like nothing happened. (only ~1 screen of errors in the log, mostly null references and object destroyed ) This is why I filed a feature request and not a bug report. It would be useful if these synced states were versioned and it was possible to roll them back. This may happen with a "normal" user with some kind of faulty drive or network mount.

Sadly as I said I detached the ram disk and destroyed every log with it.

The other one with the 35 GB instance memory bump would be more interesting, but I read around the site and it seems common knowledge that the memory management system is a mess. I took the dump with the whole browser stuck in GC loops while it tried to clean up cross-referencing zombies and extensions while the system had about 20 GB memory free. Sadly I can't really upload that. I've read most of the report, it contains more than a day of my browsing, work files and several whole tabs of long closed private windows too.

Flags: needinfo?(kullai.mate)

Thanks again for reporting this issue, but we are unable to determine the cause of the problem without the requested information. If you are able to provide this information, please just add a comment in this bug with that information and we'll get back to you as soon as we can, but in the meantime we are closing this bug so we can focus on the issues which we can address.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.