Closed Bug 1590883 Opened 6 years ago Closed 5 years ago

Unable to adjust sound level using mouse wheel

Categories

(Toolkit :: Video/Audio Controls, defect, P2)

69 Branch
defect

Tracking

()

RESOLVED WORKSFORME
Webcompat Priority ?

People

(Reporter: ksenia, Assigned: mconley)

References

(Regression, )

Details

(Keywords: regression)

As reported here: https://github.com/webcompat/web-bugs/issues/42475

Steps to reproduce:
1. In Firefox release open https://www.bilibili.com/video/av69750500.
2. Click the full screen mode button in the bottom right corner of the video player to enter fullscreen mode.
3. Use mouse wheel to adjust the volume.

Expected:
Volume indicator shows up and volume can be adjusted

Actual:
Volume indicator doesn't appear and can't adjust volume

from mozregression:

12:52.17 INFO: Narrowed inbound regression window from [ec1f3a92, 932333a3] (4 builds) to [815543d8, 932333a3] (2 builds) (~1 steps left)
12:52.17 INFO: No more inbound revisions, bisection finished.
12:52.17 INFO: Last good revision: 815543d81a1d2ab79ed4e27612dba769e4b697a8
12:52.17 INFO: First bad revision: 932333a30c717e7933a4d9d5edc91bce68d2d2b8
12:52.17 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=815543d81a1d2ab79ed4e27612dba769e4b697a8&tochange=932333a30c717e7933a4d9d5edc91bce68d2d2b8

Mike, would you be able to look into this?

Flags: needinfo?(mconley)

Yep, will investigate, thanks.

Assignee: nobody → mconley
Blocks: 1527926
Flags: needinfo?(mconley)
Priority: -- → P2

It looks like the page is using a DOMMouseScroll event listener to listen for scroll events on the video.

DOMMouseScroll is a non-standard event documented here, which includes this note:

Be aware that this feature may cease to work at any time.

It looks like somehow, by adding a UAWidget for the no-controls video case, the DOMMouseScroll event is no longer fired.

I think the right solution here is to have the site switch to the standard wheel event which is supported by all browsers: https://developer.mozilla.org/en-US/docs/Web/API/Element/wheel_event

Hey ksenia - is this enough information to go back to the site devs with?

Flags: needinfo?(kberezina)
No longer blocks: 1527926

Hi Mike, I would like to help contect the website. But it may take a while to fix. For users, this feature is good in other browsers. They may be blamed on the issue of firefox. Do we have a temporary solution before the website is fixed?

I'm afraid I'm not aware of a full workaround, no. The site is using a non-standard event that was never guaranteed to continue working. It also appears that the site is using the non-standard mousewheel event for non-Firefox browsers.

Beyond the site updating to use standard web APIs, the only workaround I can discover is to move your mouse down below the video element to the player controls, and to use the mouse wheel there.

Thanks Mike, I'll reach out to the site.
:yxu if you could contact them as well, it would be super helpful

Update: contacted via one of the emails on their contact page https://www.bilibili.com/html/contact.html

Flags: needinfo?(kberezina)

According to the STR in Comment #0, this seems fixed by the site (at least w/ my external mouse on macOS)

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.