1590943 - Language Packs for Locales should be vetted for MOZ_LANG_TITLE before being enabled

Status: RESOLVED FIXED

(Localization Infrastructure and Tools Graveyard :: Quality, defect)

Description

[Justin Wood (:Callek)]

Hey Flod,

This bug is what caused some of the confusion by Jordan during 71's cycle because, for example trs has Inglês (EU) which means the description for the addon as AMO showed it was Inglês (EU) Language Pack for tl its English (US) as well :(

because that is what gets baked into the addon itself https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/action/langpack_manifest.py#401

Is this part of the checklist and was missed, or shall we add it?

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Justin Wood (:Callek) from comment #0)

Hey Flod,

This bug is what caused some of the confusion by Jordan during 71's cycle because, for example trs has Inglês (EU) which means the description for the addon as AMO showed it was Inglês (EU) Language Pack for tl its English (US) as well :(

because that is what gets baked into the addon itself https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/action/langpack_manifest.py#401

Is this part of the checklist and was missed, or shall we add it?

It used to be part of the old documentation, but it was never ported over to the current one, and I completely forgot to check it this time.

I need to update the documentation on my side before EOY, and will include it.

Comment 2

[Francesco Lodolo [:flod]]

Additional thought: I don't think this check can be automated, it needs to be on a manual checklist.

In automation, the best I can do is to check if the key is not defined, or if "(US)" is in the translation. The latter would have still failed for trs.

Comment 3

[Axel Hecht [:Pike]]

This is documented on https://mozilla-l10n.github.io/documentation/products/firefox_desktop/adding_release.html now, can we resolve this bug?

Comment 4

[Francesco Lodolo [:flod]]

Yes, it can be closed.