Closed Bug 1590948 Opened 5 years ago Closed 5 years ago

Handling of `fxa_status` webchannel message ignores the `context` param

Categories

(Firefox :: Firefox Accounts, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: rfkelly, Assigned: rfkelly)

References

Details

Attachments

(1 file)

I happened to notice that the patch in Bug 1577690 adds support for receiving a context parameter in the fxa_status webchannel message, but doesn't correctly pipe it all the way through to the underlying shouldAllowFxaStatus helper function. Patch and tests incoming.

Assignee: nobody → rfkelly
Keywords: checkin-needed

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmpH88vBG services/fxaccounts/tests/xpcshell/test_web_channel.js Hunk #3 FAILED at 805. 1 out of 5 hunks FAILED -- saving rejects to file services/fxaccounts/tests/xpcshell/test_web_channel.js.rej services/fxaccounts/FxAccountsWebChannel.jsm Hunk #1 FAILED at 545. 1 out of 1 hunk FAILED -- saving rejects to file services/fxaccounts/FxAccountsWebChannel.jsm.rej abort: patch command failed: exited with status 256

https://pastebin.com/ghbeMgjb - services/fxaccounts/tests/xpcshell/test_web_channel.js.rej

https://pastebin.com/Q9Miu3Au - services/fxaccounts/FxAccountsWebChannel.jsm.rej

Flags: needinfo?(rfkelly)
Keywords: checkin-needed

Thanks, I have rebased and resolved the merge conflicts.

Flags: needinfo?(rfkelly)
Keywords: checkin-needed
Keywords: checkin-needed

After a bit of a battle with eslint, I believe this is ready for checkin.

Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/37f900e2a6c9
Properly inspect context param when handling fxa_status webchannel message. r=markh

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: