Handling of `fxa_status` webchannel message ignores the `context` param
Categories
(Firefox :: Firefox Accounts, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: rfkelly, Assigned: rfkelly)
References
Details
Attachments
(1 file)
I happened to notice that the patch in Bug 1577690 adds support for receiving a context
parameter in the fxa_status
webchannel message, but doesn't correctly pipe it all the way through to the underlying shouldAllowFxaStatus
helper function. Patch and tests incoming.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 2•5 years ago
•
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmpH88vBG services/fxaccounts/tests/xpcshell/test_web_channel.js Hunk #3 FAILED at 805. 1 out of 5 hunks FAILED -- saving rejects to file services/fxaccounts/tests/xpcshell/test_web_channel.js.rej services/fxaccounts/FxAccountsWebChannel.jsm Hunk #1 FAILED at 545. 1 out of 1 hunk FAILED -- saving rejects to file services/fxaccounts/FxAccountsWebChannel.jsm.rej abort: patch command failed: exited with status 256
https://pastebin.com/ghbeMgjb - services/fxaccounts/tests/xpcshell/test_web_channel.js.rej
https://pastebin.com/Q9Miu3Au - services/fxaccounts/FxAccountsWebChannel.jsm.rej
Assignee | ||
Comment 3•5 years ago
|
||
Thanks, I have rebased and resolved the merge conflicts.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
After a bit of a battle with eslint, I believe this is ready for checkin.
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/37f900e2a6c9
Properly inspect context
param when handling fxa_status
webchannel message. r=markh
Comment 6•5 years ago
|
||
bugherder |
Description
•